search

YatingMusic / remi

"Pop Music Transformer: Beat-based Modeling and Generation of Expressive Pop Piano Compositions", ACM Multimedia 2020
GNU General Public License v3.0
553 stars 85 forks source link

module 'miditoolkit.pianoroll.parser' has no attribute 'get_pianoroll' #4

Closed jjtail closed 4 years ago

jjtail commented 4 years ago

HI. This is a great project. But , I meet some wrong in chord_recognition.py module 'miditoolkit.pianoroll.parser' has no attribute 'get_pianoroll' in line 34 Isn't the function here supposed to be miditoolkit.pianoroll.parser.notes2pianoroll instead of

miditoolkit.pianoroll.parser.get_pianoroll ？ Thank u ~

remyhuang commented 4 years ago

oops. I think it is because I used an older version of the miditoolkit. As you have mentioned, it should be fixed using note2pianoroll. Could you try it for me? Then, I can revise it or you can submit a PR!

Thanks, Remy

jjtail commented 4 years ago

HI, Remy Thank you for your reply. when I modify it, it works normally. I used result / continuation.midifile and got the same result ([0:10]) as you did in the midi2remi.ipynb after using note2pianoroll fuction. But I'm not sure wether ./data/evaluation/000.midi is same file to result / continuation.midi

remyhuang commented 4 years ago

Thanks for your help! I will revise the code and close this issue. As for the result/continuation.midi, it is just an example generated result for listening.

Thanks, Remy