YatopiaMC / Yatopia

The Most Powerful and Feature Rich Minecraft Server Software!
https://yatopiamc.org/
464 stars 79 forks source link

Custom Locale stopped working #390

Open metabrixkt opened 3 years ago

metabrixkt commented 3 years ago

Expected behavior Custom locale patch checks if there's locale.json file in server directory; if there is, it uses it as server locale file.

Observed behavior Custom locale patch probably doesn't even check if there's locale.json. It doesn't use it. No warnings about locale in console.

Steps to reproduce (if known) ???

Installed plugins

> pl
[07:43:43 INFO]: Plugins (19): AntiCreeper, CartographerCrashFix, CoreProtect, EPChat*, EPModule, Geyser-Spigot, GFly, Invsee*, MultiWorld*, PacketWrapper*, PermissionsEx*, PlugMan, ProtocolLib, SimpleLay, spark, Undertow, WorldEdit, WorldEditSUI, WorldGuard

Version

> ver
[07:44:07 INFO]: This server is running Yatopia version git-Yatopia-ver/1.16.5-21 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)
[07:44:07 INFO]: Checking version, please wait...
[07:44:08 INFO]: Previous version: git-Yatopia-"89d994b" (MC: 1.16.5)
[07:44:08 INFO]: You are 1 version(s) behind

Timings https://timings.aikar.co/?id=aa7b9a2d55bd4334a29a2c09a6db1046

Additional context It worked on git-Yatopia-"89d994b" and stopped working after updating to git-Yatopia-ver/1.16.5-21.

metabrixkt commented 3 years ago

update: it happens because bungee chat api (TranslationRegistry) doesn't support custom locale since it's yatopia patch. still reproducible