search

Yawning / liballium

A C Tor Pluggable Transports Utility Library
Other
5 stars 1 forks source link

Tests failing on FreeBSD #4

Open AMDmi3 opened 8 years ago

AMDmi3 commented 8 years ago

I've just discovered that some tests fail on FreeBSD. For now, posting excerpts from test output:

== Entering suite #7, "allium_ptcfg_or_port(): OR Port" ==

VERSION 1
[7:1]  ptcfg_or_port_test:#1  "rval == ALLIUM_ERR_INVAL, NULL config"  pass
[7:2]  ptcfg_or_port_test:#2  "rval == ALLIUM_ERR_INVAL, NULL addr_len"  pass
[7:3]  ptcfg_or_port_test:#3  "rval == ALLIUM_ERR_NOBUFS, NULL addr"  pass
[7:4]  ptcfg_or_port_test:#4  "len == sizeof(v4addr), NULL buffer"  pass
[7:5]  ptcfg_or_port_test:#5  "rval == ALLIUM_ERR_NOBUFS, Length too small"  pass
[7:6]  ptcfg_or_port_test:#6  "len == sizeof(v4addr), NULL buffer"  pass
[7:7]  ptcfg_or_port_test:#7  "rval == 0, Valid IPv4 address"  pass
[7:8]  ptcfg_or_port_test:#8  "v4addr matches"  FAIL
!    Type:      fail-unless
!    Condition: 0 == memcmp(&v4addr, &cmp_v4addr, len)
!    Line:      622
VERSION 1
[7:9]  ptcfg_or_port_test:#9  "rval == 0, Valid IPv6 address"  pass
[7:10]  ptcfg_or_port_test:#10  "v6addr matches"  FAIL
!    Type:      fail-unless
!    Condition: 0 == memcmp(&v6addr, &cmp_v6addr, len)
!    Line:      635

--> 10 check(s), 8 ok, 2 failed (20.00%)
== Entering suite #8, "allium_ptcfg_ext_port(): Ext Port" ==

VERSION 1
[8:1]  ptcfg_ext_port_test:#1  "rval == ALLIUM_ERR_INVAL, NULL config"  pass
[8:2]  ptcfg_ext_port_test:#2  "rval == ALLIUM_ERR_INVAL, NULL addr_len"  pass
[8:3]  ptcfg_ext_port_test:#3  "rval == ALLIUM_ERR_NOBUFS, NULL addr"  pass
[8:4]  ptcfg_ext_port_test:#4  "len == sizeof(v4addr), NULL buffer"  pass
[8:5]  ptcfg_ext_port_test:#5  "rval == ALLIUM_ERR_NOBUFS, Length too small"  pass
[8:6]  ptcfg_ext_port_test:#6  "len == sizeof(v4addr), NULL buffer"  pass
[8:7]  ptcfg_ext_port_test:#7  "rval == 0, Valid IPv4 address"  pass
[8:8]  ptcfg_ext_port_test:#8  "v4addr matches"  FAIL
!    Type:      fail-unless
!    Condition: 0 == memcmp(&v4addr, &cmp_v4addr, len)
!    Line:      691
VERSION 1
[8:9]  ptcfg_ext_port_test:#9  "rval == 0, Valid IPv6 address"  pass
[8:10]  ptcfg_ext_port_test:#10  "v6addr matches"  FAIL
!    Type:      fail-unless
!    Condition: 0 == memcmp(&v6addr, &cmp_v6addr, len)
!    Line:      704
VERSION 1
[8:11]  ptcfg_ext_port_test:#11  "rval == ALLIUM_ERR_PTCFG_NO_ADDRESS, No Ext Port"  pass
[8:12]  ptcfg_ext_port_test:#12  "len == 0"  pass

--> 12 check(s), 10 ok, 2 failed (16.67%)
== Entering suite #9, "allium_ptcfg_bind_addr(): Bind Addr" ==

VERSION 1
[9:1]  ptcfg_bind_addr_test:#1  "rval == ALLIUM_ERR_INVAL, NULL config"  pass
[9:2]  ptcfg_bind_addr_test:#2  "rval == ALLIUM_ERR_INVAL, NULL addr"  pass
[9:3]  ptcfg_bind_addr_test:#3  "rval == ALLIUM_ERR_INVAL, NULL addr_len"  pass
[9:4]  ptcfg_bind_addr_test:#4  "rval == ALLIUM_ERR_PTCFG_INVALID_METHOD, Invalid method"  pass
[9:5]  ptcfg_bind_addr_test:#5  "rval == ALLIUM_ERR_NOBUFS, NULL addr"  pass
[9:6]  ptcfg_bind_addr_test:#6  "len == sizeof(v4addr), NULL buffer"  pass
[9:7]  ptcfg_bind_addr_test:#7  "rval == ALLIUM_ERR_NOBUFS, Length too small"  pass
[9:8]  ptcfg_bind_addr_test:#8  "len == sizeof(v4addr), NULL buffer"  pass
[9:9]  ptcfg_bind_addr_test:#9  "rval == 0, Valid IPv4 address"  pass
[9:10]  ptcfg_bind_addr_test:#10  "v4addr matches"  FAIL
!    Type:      fail-unless
!    Condition: 0 == memcmp(&v4addr, &cmp_v4addr, len)
!    Line:      778
[9:11]  ptcfg_bind_addr_test:#11  "rval == 0, Valid IPv6 address"  pass
[9:12]  ptcfg_bind_addr_test:#12  "v6addr matches"  FAIL
!    Type:      fail-unless
!    Condition: 0 == memcmp(&v6addr, &cmp_v6addr, len)
!    Line:      785

--> 12 check(s), 10 ok, 2 failed (16.67%)
==> 135 check(s) in 15 suite(s) finished after 0.00 second(s),
    129 succeeded, 6 failed (4.44%)
AMDmi3 commented 8 years ago

Fixed by #5

AMDmi3 commented 8 years ago

PS. Would be nice to tag 0.0.2 with this. master branch already contains useful commit since 0.0.1 tag.