Ybalrid / Annwvyn

Annwvyn C++ Open Source designed-for-VR game engine and application developement framework
MIT License
41 stars 7 forks source link

AnnConsole::Write to texture : remove usage of new[]/delete[] for Glyph Texture Coordinate array #139

Closed Ybalrid closed 7 years ago

Ybalrid commented 7 years ago

The WriteToTexture method is storing the coordinate for the "texture mapped font" inside a raw array that is allocated by hand with new[] and deleted in a "goto cleanup". That's code copy pasted from a wiki. It should be modernized an maybe rewritten because it is quite confusing.

In any case. There should be a vector here, not a array dynamically allocated with new[]

Ybalrid commented 7 years ago

Fixed in commits 133184456ea3b683587a417cefbfa7f203737ece and 66a57f1e6e7ba1f23901edcc677988f111c15e4c