Fix issues on Chalk and Aplite

YclepticStudios / pebble-7-min

7 minute workout for your Pebble watch!

MIT License

18 stars 5 forks source link

Fix issues on Chalk and Aplite #1

Open leomike opened 8 years ago

leomike commented 8 years ago

Chalk only:

Center circle was made smaller
Text was moved up slightly
Text was allowed to wrap to the second line
Vibrate twice due to weaker vibration on the PTR

Aplite only:

Play/pause are now properly displayed as gray (note that dark gray is not implemented, the if statement could be removed)

appinfo.json was automatically reformatted by CloudPebble

YclepticStudios commented 8 years ago

Thanks for the fixes! There is one issue which needs to be addressed. I was testing your changes, and I found that on Aplite, the center control (play/pause) no longer displays as greyscale. It is solid black now. This will need to be addressed before I merge.

leomike commented 8 years ago

When I compile the current version from your repo it also displays as black. I don't have an Aplite device so I can't test it with a real device but I'm thinking this might be an issue with the emulator in the latest firmware. I've been seeing strange behavior with Aplite on other projects (e.g.: bitmaps randomly disappearing).

YclepticStudios commented 8 years ago

Hmm... Interesting! In that case, I will take a look at it and see if there is something I need to update for the latest SDK. Perhaps something changed which affects only Aplite. If you happen to find out, let me know as well.

YclepticStudios commented 8 years ago

Looks to me like graphics_context_set_compositing_mode with GCompOpOr is broken.

leomike commented 8 years ago

It seems like using a color of GColorLightGray works to display the lighter gray, but I can't seem to get the darker gray used during the breaks.

leomike commented 8 years ago

Sorry, meant to push this fix to a separate branch. It partially fixes the issue by displaying as light gray in all cases (although the if statement could be removed). I can re-commit to a separate branch and request a new pull to have a clean commit history.

Edit: Confirmed that both Light and Dark gray map to 50/50: Pebble Blog

YclepticStudios commented 8 years ago

I've been playing with it for a little while, and I have come to about the same point as you. I am not sure if there is any way to easily generate a darker grayscale without being able to set the compositing mode.

However, I actually don't think it is too bad to have the button stay as a light grey and the background turn to dark. It is not optimal, but I don't dislike it... I will have to play with it and see how I feel about it. Unless I figure out a better way, this may be the way I publish it.