YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.9k stars 522 forks source link

Options no longer work. #1018

Open EeveeA opened 9 years ago

EeveeA commented 9 years ago

Bug: http://a.pomf.se/ldjypk.mp4 Explanation: Seemingly - Once you click options, it send you to YouTube with YTC's Over-lay for the options, however it seems to be frozen, then 5 seconds later freezes. I used to use this a lot, but had to format my computer and just got around to adding YTC again 2 days ago. So this version should be second from latest; 404.

Question: Is there a way - in the files - to get my settings? Since I can't use the YTC UI to extract the options.

Yonezpt commented 9 years ago

Could you try disabling all the other addons you have installed except for the YTC addon? It feels like some addon (like an ad blocker) might be forcing the settings to close. There are addons that have rules which are specific for when a webpage displays an overaly blocking the entire page, like the YTC settings menu does.

evelynharthbrooke commented 9 years ago

Looks like it might just be an issue on your end with one or some of the extensions you have installed, as I'm able to access the YouTube Center options just fine without YouTube freezing.

EeveeA commented 9 years ago

That was indeed the cause. Now, While I can make an acception for YTC, you think this is something YTC can fix in their end/evade Ad-block?

YePpHa commented 9 years ago

@EeveeA I will not be doing anything to fix this now, but I have some plans on possibly moving the whole settings onto a separate page like other extensions.

evelynharthbrooke commented 9 years ago

Here's a suggestion, uninstall normal AdBlock and replace it with Adguard. It works excellent with YouTube/YouTube Center.

YePpHa commented 9 years ago

Adblock Plus also works quite good and doesn't break anything related to YouTube Center.

Yonezpt commented 9 years ago

As @YePpHa suggested, adblock plus works well, it is the one I am using also and so far there have been no conflicts with YTC in Chrome.

@YePpHa Won't that be a too drastic method? I have been playing with my script and I have been using the settings menu as an absolutely positioned div inside the div#body-container. It works well, the user can scroll up or down, and it doesn't mess up the already existing content/thumbnail scroll event listeners because it is basically sharing the same size and space as youtube's current content.

If you want to try it out simply copy and paste this node as a child of div#body-container

<div id="ytc-overlay-box" style="background: #f1f1f1; height: 100% ; left: 0; position: absolute; right: 0; z-index: 10;">
    <div id="ytc-settings-menu" style="background: #b1b1b1; margin: 60px auto 0; height: 500px; width: 1056px;">
        Settings menu stays here
    </div>
</div>

background, width and height are just there so that the node can be seen when applied

Also forgot to say, it might be a good idea to send the user to the top of the window when the settings menu opens, otherwise he might be at the bottom of a big page and wondering why the settings menu never shows up.

EeveeA commented 9 years ago

Well, I would GREATLY appreciate a separate page! I personally think that would be generally more efficient as-well.

YePpHa commented 9 years ago

@Yonezpt I would think that having a separate page for the Chrome and Firefox extension would be more efficient as people would not have to go to YouTube to change their settings. I would most likely still keep the current settings dialog.

Yonezpt commented 9 years ago

@YePpHa I understand the intentions, but I wonder if this won't create another similar issue as the one reported in this thread, but this time it will be caused by pop-up blockers that block the YTC settings page.

YePpHa commented 9 years ago

@Yonezpt I will keep that current settings dialog to appear when you click on the settings icon on the YouTube page, but I will add an extra settings page which can be accessed by clicking on options in the extensions page.

Yonezpt commented 9 years ago

@YePpHa That sounds like a really good solution.