YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 520 forks source link

enforcing SPF breaks "timecode-links" #1140

Open Djfe opened 10 years ago

Djfe commented 10 years ago

if I opened the video from a different youtube page (another video) for example through recommendations then the timecode-links don't work correctly anymore ->it will scroll up to the video but won't change the current playback time

If I reload the video page completely then the links work correctly

don't know if it matters but I'm defaulting to the flash player as the fps is better on my laptop

Yonezpt commented 10 years ago

Information about the browser and YTC version that you are using would be helpful. Also youtube recently shipped SPF by default for Firefox and IE11 (perhaps to other browsers as well) so if you are using one of these then don't force SPF.

To confirm that your browser has SPF by default simply turn off YTC and navigate in youtube, if a red bar appears on the top then SPF is enabled by default.

Djfe commented 10 years ago

I'm using the Firefox release, but SPF wasn't enabled by default...

Yonezpt commented 10 years ago

Which Firefox version are you using? I am currently using Firefox 33.0.3 and SPF is running by default in youtube with the youtube center dev version 419 addon disabled.

Djfe commented 10 years ago

I haven't tested it with YTC disabled but when it is disabled in YTC then everything works fine if it's enabled in YTC then the issue described above is happening

EDIT: without YTC it's enabled, yes but clicking on these timecode-links works, so this is a YTC bug since it only appears when YTC is activated I'm using 33.0.3, too btw. (release)

Yonezpt commented 10 years ago

This is a recent change to youtube and the addon hasn't been updated yet to accomodate that change, so until then leave it the way it works or the way you prefer best until YePpHa updates the addon.

Djfe commented 9 years ago

I only wanted to report the issue and not urge him I'm patient :)