search

YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 520 forks source link

Sidebar covers video when you click a video link #1188

Closed mtfurlan closed 9 years ago

mtfurlan commented 9 years ago

If I play a video, then click any of the videos in the sidebar, this happens

issue image

If I refresh the page, it looks normal, like this

normal image

The settings popup still works, and nothing shows up in the firebug console as an error.

I'm running firefox 33.1 on win7. I have noscript, but I've allowed everything on youtube. I also have flashblock, but disabling that also does nothing.

I have reinstalled the youtube centre usercript, as the last time I installed it was from userscipts.org, but no change.

I'm not sure how long this issue has been happening.

Yonezpt commented 9 years ago

If you are not using the developer version can you try it and let us know if the problem still persists? You can download it here: https://github.com/YePpHa/YouTubeCenter/wiki/Developer-Version

mtfurlan commented 9 years ago

Installed the developer version, confirmed that it was installed and the normal version disabled, and it still happens.

mtfurlan commented 9 years ago

I just realized, I'm going to be reinstalling windows in the next day or so for unrelated reasons, so unless you really want to debug my random issue before I reinstall(In which case I can push off reinstalling a few days), just close this issue. Sorry about that, didn't really think about it till just now.

Yonezpt commented 9 years ago

Could you try resetting the YTC settings to their default? If it still happens then the last thing to try is to disable all other addons you might have except YTC to see if any addon is causing a conflict.

YePpHa commented 9 years ago

It's possibly due to SPF and the correct classes are not applied to the body. If you need to reinstall your computer I would recommend you to post the debug log (Settings -> Debug -> Log) and save the HTML page (CTRL + S) when this bug has occurred. Afterwards, just reinstall your computer as I probably can't use much more than that.

mtfurlan commented 9 years ago

http://scuzzball.net/science/ http://pastebin.com/vFmqDnH0 Sorry I can't be much more help, but good luck. Tell me when you don't need those files anymore.

YePpHa commented 9 years ago

It seems as though YouTube Center's CSS classes haven't been applied to the page. I will try to figure out why this happened. I have downloaded both files so you can delete them if you want.

mtfurlan commented 9 years ago

So it showed up again after reinstall. Found out that either I was lying, or firefox sync didn't sync stuff I thought I did yesterday(Install dev version of userscript).

Turns out I had the youtube center firefox addon installed. I disabled it, and tried the userscript version. Works fine. Both the dev version and the normal version of the userscript work fine.

I started a clean firefox profile, tested the addon version. Works. I would say this means that it's some kind of conflict with firefox plugins.

On the plus side, it's easily replicable. List of installed addons: http://pastebin.com/i83VqJxQ

Side note: there was an odd difference, with the addon version, the area behind the video was darkened, a div with id theater-background. This doesn't happen in the greasemonkey version. This is actually how I figured out there was a difference, when I started a new profile and installed the userscript version it was different, and I couldn't figure out why.

YePpHa commented 9 years ago

It's definitely an issue with the body classes not being applied to the DOM. I try to figure out why this is happening.

YePpHa commented 9 years ago

Just noticed that you're using YouTube Center v2.1.0. Please, could you try to install the latest v2.1.6 or the developer version and test if it's then working.

mtfurlan commented 9 years ago

The developer version works fine. Just so you know, the version I had is the version from the firefox addon site

YePpHa commented 9 years ago

I have to separate images from the main part of YouTube Center before I can upload a new version. I have planned to get this done before v2.1.7.

mtfurlan commented 9 years ago

Okay. Sorry about all of this, I guess I just really fucked up on the verifying what was installed and then installing stuff. Issue can be closed now, yes?