search

YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 520 forks source link

External Player settings have no effect on embedded players #1289

Open EgorkaSanyok opened 9 years ago

EgorkaSanyok commented 9 years ago

Any settings I try doesn't affect the embedded player. It's been this way for a while, at least 20 builds I'd say.

Firefox 34 YTC 456

ireun commented 9 years ago

Same here, i've set external player resolution to 1080p, but i still plays 480p on embedded players. Latest, DEV, Chrome Beta, HTML5 player..

Lucatir commented 9 years ago

Can confirm that external players don't get passed YTC settings as they still appear as flash players for me even though I've set them to HTML5 even on YT's side. Firefox 36 & YTC Dev 459 add-on.

fireattack commented 9 years ago

"Auto-resolution" does work on external player when using Userscript version but not Fx's xpi version I can confirm.

And "Only one player instance playing" doesn't work on any AFAIK.

Djfe commented 9 years ago

happens to me as well, I'm using the xpi version

html5 player works fine for me (I enabled it at youtube.com/html5) but it depends on the video, whether youtube sends you html5 or not (there are some video where it sends flash still)

Zialus commented 9 years ago

I can confirm that the settings for the external player only work with the Userscript and not with the extension.

Tested both with Firefox 36 YTC 471

fireattack commented 9 years ago

Sorry for bumping. But it's weird this important bug didn't get any attention. Considering it's a regression I suppose it should be easy to fix?

Djfe commented 9 years ago

Only if the regression was caused by YePpHa which is unlikely IMHO. The regression was rather caused by code changes by YouTube.

I don't experience this anymore/don't know whether this bug is still in, because I switched to the userscript version -> auto update (dev version) saves time :)