search

YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 519 forks source link

Lost buttons on player pages #1467

Open Ghosthree3 opened 9 years ago

Ghosthree3 commented 9 years ago

Not sure when it happened, but it was very recent, the script still takes effect as the player is set to my preferred size and the lights go out. However there is no settings button, no lights button, no download/anything else button. Also the share part under the video is showing again.

YePpHa commented 9 years ago

Please, would you tell me what browser you are using?

I'm not sure what could cause this. However, please go into the JavaScript console (CTRL + SHIFT + J, F12, CTRL + SHIFT + K) and post the content of it here.

ghost commented 9 years ago

Experiencing the same issue.

JavaScript console output: http://pastebin.com/raw.php?i=at4LhLtD about:buildconfig: http://pastebin.com/raw.php?i=ebAs20ic

untitled

YePpHa commented 9 years ago

It's possible that this is the issue:

Security wrapper denied access to property toString on privileged Javascript object. Support for exposing privileged objects to untrusted content via __exposedProps__ is being gradually removed - use WebIDL bindings or Components.utils.cloneInto instead. Note that only the first denied property access from a given global object will be reported. YouTubeCenter.user.js:25731
YePpHa commented 9 years ago

Is this issue also occurring if you're using Greasemonkey instead of the Firefox addon?

Ghosthree3 commented 9 years ago

I am using Greasemonkey + script instead of the addon yes. I'm actually using Pale Moon but it should be close enough to Firefox that my issue is the same as mrzerodk's.

ghost commented 9 years ago

I use the Greasemonkey script.

untitled

I installed the Firefox extension to test it out and I can report that it works fine. Buttons are once again visible.

untitled JavaScript console with the extension: http://pastebin.com/raw.php?i=42Ztf13e

YePpHa commented 9 years ago

I think that the issue might be solvable by resetting the settings. If it's the buttons that don't appear a simple reset to the stored references should make YouTube Center recreate them, which might very well fix it.

Ghosthree3 commented 9 years ago

I reset the settings which did bring everything back on the player page. However, when I went and manually set all the settings back to what they were before it messed up again. Guess there's a bugged option somewhere, I'll try to narrow it down.

Ghosthree3 commented 9 years ago

Ok, setting the Player Type on the Player tab to HTML5 is what breaks it. No idea why. Changing it back fixes it.

ghost commented 9 years ago

I can confirm that as well. I changed player type back to default and buttons reappeared.

JavaScript console log: http://pastebin.com/raw.php?i=b2J51gLH

I should note that I do not have flash installed and when changed back to default player type, youtube still plays in HTML5 however it is only when I specifically set the player type to force HTML5 the buttons disappear.