search

YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 521 forks source link

Watch Later underlying HTML changed. Watch Later button only works if clicked on the edges #1630

Open allbetsareoff29 opened 9 years ago

allbetsareoff29 commented 9 years ago

Watch later button is broken now. dev#497, chrome. It only works if you click the edge of the button (the NON-clock part).

in the source code, problem is at:

pseudo:before is responsible for that clock img being overlayed over the top of "watch later" button. Concurrently, it is also blocking the buttons onClick()

either removing the :before fixes it, or changing it's display property to none, or changing it's content property to none... either way... pseudo:before has no onClick and thus blocking the onClick of the whole "watch later button

LafinJack commented 9 years ago

"only works if clicked on the edges"

haha what

Bugs get so weird and specific sometimes.

allbetsareoff29 commented 9 years ago

the more specific I am, the easier it is to debug and fix. I'm developer myself and there is nothing that makes me rage more than when client comes to me and says "It doesn't work" and I ask them what is wrong with it, and they say, "I don't know, it just feels off".

On Wed, Apr 8, 2015 at 10:19 PM, LafinJack notifications@github.com wrote:

"only works if clicked on the edges"

haha what

Bugs get so weird and specific sometimes.

— Reply to this email directly or view it on GitHub https://github.com/YePpHa/YouTubeCenter/issues/1630#issuecomment-91093255 .

LafinJack commented 9 years ago

Oh no, I don't mean your description, I mean the change on Youtube's end that made it break. :)