YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 520 forks source link

Fill Screen (resize) no longer working. #1844

Closed crzyflyinazn closed 9 years ago

crzyflyinazn commented 9 years ago

Running developer build 525 and this issue just popped up today. I haven't touched any of my settings in the extension or in chrome.

yt

DejayRezme commented 9 years ago

Thanks Cellane the new player fixed it for now! And thank you YePpHa for your great work, YTC really makes youtube much better.

Cyguard commented 9 years ago

Slight problem with the HTML5 player. Playlists don't function like they should. By that i mean it doesn't go to the next video on its own. This is likely not an issue with YTC though.

evieluvsrainbows commented 9 years ago

@Cyguard Well, they are still working on it. What do you expect? :smiley:

Cyguard commented 9 years ago

@KamranMackey upon further testing it is YTC at fault for not going to the next video in the list. not that big a deal though.

ghost commented 9 years ago

Thanks for the testtube player suggestion. That fixed it. Hopefully there's a real fix soon. :)

MammothJerk commented 9 years ago

the testtube fix worked for me but now i cant play the video as usual.

with autoplay off which is how i prefer it, whenever i open a video its just all black, and i have to press spacebar for the video to play and it wont buffer unless i press spacebar

in the old player it would buffer while still not playing.

if i turn the prevent autoplay off in the ytc options when i open several tabs they will all start playing and lagg my browser to hell, even when i have the "Only one player instance playing" turned on very annoying when you use your tv for youtube and you dont have a keyboard handy.

ngld commented 9 years ago

I can confirm that YePpHa's fix works. I replaced line 10989 with if(1) { to test it.

markreg commented 9 years ago

@ngld Perfect fix. Just rewrite function fixPlayerSize to window.matchMedia = null.

MammothJerk commented 9 years ago

@ngld Worked for me aswell

Yonezpt commented 9 years ago

If anything, changing the original function into this would be best:

Original

function fixPlayerSize() {
    if (isNewPlayer()) {
        window.matchMedia = null;
    } else {
        patchDetour();
    }
}

Changed fix

function fixPlayerSize() {
    window.matchMedia = null;
}
SuperSajuuk commented 9 years ago

I had to take the plunge and switch to the new player, simply because the old player was pushing the content down a bit from the top (meaning a small section at the bottom of content was cut off completely). Are any updates "actually" going to appear, or is this just going to become abandoned? Heard nothing from @YePpHa in ages and no updates in at least a week :/

rotemdan commented 9 years ago

@Yonezpt Thanks for the solution (would have taken many hours or even days to figure that out myself). I got tired of waiting for YTC to be fixed and instead made a new userscript with the features I considered the most important (and some that were not available in YTC at all) based on my personal preference for customization. I called it "YouTube Cinema Mode" (link is to Greasyfork, but might be on GitHub in the future). Here's the current feature list:

Supports the HTML5 player only. Tested with both the latest Firefox and Chrome (using latest Greasemonkey/Tampermonkey). Works with both the old (black/red) player and the newer, transparent one, which can be enabled here (recommended).

I tried to organize the code so other developers could benefit from the individual features (feel free to copy/paste into your own scripts). Because of duplicate and conflicting behaviors, it doesn't seem to work well alongside YTC though (that would also depend on the particular YTC settings used).

EDIT: A GitHub repository has now been created for the script.

evieluvsrainbows commented 9 years ago

@YePpHa Are you gonna fix this issue natively in YouTube Center soon or what? Not trying to be mean, but you haven't pushed a commit to YouTube Center in literally over a month. What's going on? I hope YouTube Center isn't being abandoned.

Yonezpt commented 9 years ago

@KamranMackey I think in Europe, around these months, is the exams season. If he is studying then he is very likely unable to have enough free time to update YTC since some of those exames require the students to study for an entire month non-stop, in some cases up to 2 months.

But that is if he is studying, I am just guessing here so it might be something completely different.

SuperSajuuk commented 9 years ago

@KamranMackey @Yonezpt Based on his profile pic, he doesn't really strike me as the kind of person who would be studying for exams, but appearances don't tell the whole story ;)

But yes, I'm starting to believe the extension is abandoned, unless he commits something soon. And if it's abandoned, it'll need community involvement to fix things. I don't mind if we get spammed with updates and asked to confirm if the update fixed things, that's the goal of a developer build. >_>

GarfieldDeepClone commented 9 years ago

Don't let that great script die....

ghost commented 9 years ago

Do you have this issue when using a fullscreen player? The video doesn't even "fit" the screen.

2015-06-17 16_36_37-ask mkbhd v4

GarfieldDeepClone commented 9 years ago

Did I miss something? Is there a solution or has the script been abandoned?

Yonezpt commented 9 years ago

@GarfieldDeepClone A temporary solution has been presented above: https://github.com/YePpHa/YouTubeCenter/issues/1844#issuecomment-111477296

foss- commented 9 years ago

Can someone update the title? This was not restricted to chrome only but also happened in Firefox (several users did report so).

Also in latest FF 39.0 + YTC dev 528 I have not been seeing this any longer.

Thanks for keeping this alive and continuous development efforts!

ireun commented 9 years ago

@foss- Done, this will be now a main issue about bugged player resizing, and every duplicate will get closed. ;)


Also, i think this is a first issue about this, which, I think, has been fixed back than: #1017.

Yonezpt commented 9 years ago

@foss- This issue has already been fixed in dev. 526

@ireun This issue can be closed as far as I can see.

ireun commented 9 years ago

Sure, if you want, feel free to close issues for yourself. ;)

Wolf68k commented 9 years ago

Not fixed yet. Happening in dev.528

Yonezpt commented 9 years ago

@Wolf68k Can you provide screenshots of the issue? Because there is a very similar one that might be mistaken by this one, however it is being caused by a Firefox setting, not by YTC (see issue 1812)

Ignore this, update YTC to 529, YePpHa just pushed a fix for the issue: https://github.com/YePpHa/YouTubeCenter/commit/83300554b64355de1e3d410b3d53009335cccaf1

welwood08 commented 9 years ago

To offer a second data point, this issue had been fixed for me in Firefox until some time today. The issue resurfaced without me making any change in either YTC or Firefox settings. YTC build 529 fixes it again.