search

YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 519 forks source link

Flags of countries are displayed partially #2353

Open Hobbix opened 7 years ago

Hobbix commented 7 years ago

Flags of countries are displayed partially youtube

P.S. This fix does not work? https://github.com/YePpHa/YouTubeCenter/commit/0bdf003290e35acbf1c639870481c2b40bf236a7

YePpHa commented 7 years ago

The question mark flag is shown because it can't determine the country of origin. It's not all user's that has this particular feature enabled.

Yonezpt commented 7 years ago

Unless the users have their country explicitly visible in their YouTube settings there is no way to obtain the country.

In your screenshot, if you go the the About page of the user Yusuf Hashim you can see his Country explicitly visible to anyone: https://www.youtube.com/channel/UCbGPuVTy9G96MOk2kSAHZLQ/about

But if you go to the About page of the other users they either don't have the About page at all or their Country is not visible in that page.

A more appropriate default handler would be to not show the country flag if the user does not have its country information available.

joridiculous commented 7 years ago

@Yonezpt Doesn't load even if country is in About. Just tried my own account.

Yonezpt commented 7 years ago

@joridiculous if you changed it recently to test it then it shouldn't take effect immediately, the servers need to update your info in their API as well, which can take some time.