YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 520 forks source link

"{pubyear}-{pubmonth}-{pubdays} Filename elements not working. #2354

Open ArJunaZ opened 7 years ago

ArJunaZ commented 7 years ago

The file naming date function has never worked for me for many years, through MANY Firefox and Waterfox builds on multiple PC's.

Today for the first time I am pretty sure I saw it work, but it must have been a one time fluke.

I've saved literally thousands of files with YouTube Center Dev. Build and That was the first time EVER I saw "{pubyear}-{pubmonth}-{pubdays}" actually work in the download filename formatting. However, when I tried it again just now (no change in build #) it did not work on the same PC. I also installed #544 and those "{pubyear}-{pubmonth}-{pubdays}" elements are still not working.

Over the years I've gotten used to replacing the "0-0-0" date manually, but it would be really nice if it worked and if the other issue where low resolution videos now popup in a new window instead of generating a "Save as." dialog box to save the file with the file naming formatting working.

YePpHa, If you are planning to keep this excellent plugin current for a while I would be happy to chip in and send you $10 via PayPal.

ArJunaZ commented 7 years ago

OK, this is odd. The date function is working for some videos, but not others. I am currently running Dev Build #544

Here is my configuration for the filename formatting option: {pubyear}-{pubmonth}-{pubdays} - {title} [{videoid}] {resolution} {durmins}min

I will list some YouTube videos and show the filename results on some that worked and some that don't.

Here are a couple examples of YouTube Videos where it worked:

https://www.youtube.com/watch?v=nXYyafFwv_w "2017-02-07 - MARC LAMONT HILL & The BOULE-Black Greek Fraternities-_Negro ILLUMINATi EXPOSED!! [nXYyafFwv_w] 720p 29min.mp4"

https://www.youtube.com/watch?v=X0E-ScqWkMk "2017-02-06 - China's Rover NOT ALONE On The Moon 2-6-17 [X0E-ScqWkMk] 720p 13min.mp4"

Here are a couple of videos where it does not work:

https://www.youtube.com/watch?v=PGVSzIKaIqY "0-00-00 - It's not theft if it's for the common good #taxationistheft [PGVSzIKaIqY] 720p 06min.mp4"

https://www.youtube.com/watch?v=7vRHwTZCt7Q "0-00-00 - Donald Trump - Illuminati Puppet Exposed - Part 2 [7vRHwTZCt7Q] 720p 11min.mp4"

All this is still much better than before when the date portion NEVER worked for me for years. Thanks again for your work on this.

ArJunaZ commented 7 years ago

FYI. Dev Build #546 did not impact this issue. It still works on some videos and not others.

Inyokus commented 7 years ago

When I dug into that recently because of Choonster's pull request I was wondering how the {channelname} placeholder (and the publication time ones) for the download file name are supposed work:

As far as I can see, the filename gets generated by ytcenter.video.getFilename, which is called by $CreateDownloadButton, which in turn gets called by pageSetup on bodyInteractive or SPF's done event. However, the channel name and the publication time are gathered asynchronously and that need not be finished (and likely did not finish) by then.