YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 520 forks source link

Progress bar doesn't reach all the way across the player #809

Closed sam-the-enby closed 9 years ago

sam-the-enby commented 10 years ago

I'm using chrome and the version from the chrome store. The progress bar only reaches part way across the player. This happens on every video, regardless of settings. Using the flash player fixes it, so I guess it's a html5 problem.

sample

JBey4you commented 10 years ago

Same problem here, I'm using the Developer Version and the HTML5 player with Chrome on OS X. It doesn't happen all the time though.

It's so random, I have no idea how to reproduce it... capture decran 2014-08-07 a 04 46 51

Ofunniku commented 10 years ago

I can confirm the same issue, when I try to buffer the entire video, it stops. (DASH disabled, Prevent Auto-play, Prevent Auto-Buffer is unchecked)

PS: YTC 2.1.5, Fx 31, Flash 14.0.0.145, Windows 7 64-bit.

Zageron commented 10 years ago

I have also encountered this issue. It only occurs when using the resize feature. When it is disabled the progress bar works as intended. http://www.zageron.com/img/20140807043003701.png

Spec: https://aboutmybrowser.com/dfs-fAeD

Dabarti commented 10 years ago

For me, changing "Player Type" to "Aggressive flash" helped. Not sure what is causing this problem.

caeldom commented 10 years ago

YTC Dev Build # 369 (Userscript via Tampermonkey) Chrome 38.0.2114.2 dev-m (64-bit) Windows.7 64bit

Having the same issue of progressbar not stretching to the end, for every video. I also believe the HTML5 player is responsible as changing back to Flash or Aggressive Flash fixes it for me. One thing to note is the bar has simply been resized down to its usual length for the YouTube default size player. Changing to Cinema mode will resize the bar to the relative length for that player size. So my guess is they've changed something small in the HTML5 for the resizing of the progressbar, perhaps a property or method name.

Yrlish commented 10 years ago

Can confirm the same, YTC 2.1.5

Ofunniku commented 10 years ago

Sorry, caeldom, it's actually a buffering issue. I can confirm it by watching my network graph, it stops transfers after buffering a certain amount when paused or when autoplay is prevented, then when I start playback, it will transfer "chunks" that shows as spikes on network activity during playback, the very thing I am trying to avoid by disabling DASH.

greatwroth commented 10 years ago

same here, html5 player on Build 369 firefox extension, it also causes annotations to scale, does not happen in fullscreen

Yrlish commented 10 years ago

Oh, yeah. The annotations too.

caeldom commented 10 years ago

@Ofunniku can you attach a screenshot of what it looks like for you? Sounds like you may be experiencing a different or separate issue because the problem identified here is not with where the video has buffered to on the bar, but rather the entire bar itself has been shortened, relative to the rest of the controlbar. Since you mentioned DASH, I assume the issue you're experiencing is that although you've disabled DASH, it still behaves like it's enabled, and buffering "blocks" of the video instead of preloading the entire thing at once. You may want to bring your issue up in another ticket.

The image below should clarify.

image

The issue is with the HTML5 player not stretching the progressbar to its full size within the player. If I were to keep playing, the buffering would continue up until what seems to be the "cropped" end of the progressbar, but would be 100% of the video. Likewise if I were to click to the end of the progressbar, it would bring me to the end of the video.

ghost commented 10 years ago

I also encounter this issue

Zageron commented 10 years ago

Confirmed that using Aggressive Flash solves the issue.

jakebailey commented 10 years ago

I seem to be able to fix the issue by hitting the player size button (just to the left of full screen). Once it's in theater mode, the bar stretches across. That might just be dependent on player size (I have a custom size that locks video to 720px high), but it might help for some.

Ghosthree3 commented 10 years ago

The problem is the HTML5 player, or how this script uses it.

raduflp commented 10 years ago

Same problem here. Nothing too bad, but i must say it's annoying.

YePpHa commented 10 years ago

Fixed in latest dev version.

Yrlish commented 10 years ago

Awesome! When will that be out on the stable branch thingy?

YePpHa commented 10 years ago

@Yrlish I'm not sure. When I think it's ready.

It seems like the fix isn't applied to the player always. I will try to get this sorted.

Yrlish commented 10 years ago

Oh, I see. Thanks for the information and good work! c: I will just have to wait for the next update then. :)

foss- commented 10 years ago

1+ another effected user. chromium Version 36.0.1985.125, dev version fixes this I can confirm.

pietrodn commented 10 years ago

+1 with YTC 2.1.5 on Google Chrome 36.0.1985.143. Setting "player type" on "Flash" fixes it.

YePpHa commented 10 years ago

@pietrodn Yes, this bug is only present on the HTML5 player.

Yrlish commented 10 years ago

@pietrodn Some people doesn't want to use Flash and prefer HTML5 over it by multiple reasons. Even this small, just annoying issue doesn't makes us switch to Flash.

YePpHa commented 10 years ago

@Yrlish don't worry this has already been fixed in the developer version and I will soon release a new version of YouTube Center.

Yrlish commented 10 years ago

@YePpHa Yes, I know. :P

pietrodn commented 10 years ago

@Yrlish I didn't want to minimize the relevance of this bug: I just wanted to confirm that I was getting the same behaviour as others. :)

ireun commented 9 years ago

Probably related to #1117. Closing as this is fixed already.