search

YePpHa / YouTubeCenter

YouTube Center is a userscript designed to expand the functionality of YouTube. It includes the ability to download the video you're watching, auto selecting your preferred video quality and much more.
MIT License
2.89k stars 519 forks source link

playlist auto play broken in HTML5 player #946

Open greatwroth opened 10 years ago

greatwroth commented 10 years ago

"Playlist auto play" option no longer works; whether it is enabled or disabled it will not go to the next video in a playlist. (and I did make sure the auto-play playlist button is toggled on the video page)

I believe this may have been the result of build 394 fixing issue #885

Firefox extension build 394

greatwroth commented 10 years ago

I'm pretty sure the playlist auto play freeze option would make no difference judging by the button's description. I've tried it enabled and disabled and it is currently disabled as per usual.

YePpHa commented 10 years ago

@greatwroth I will take a look at it.

greatwroth commented 10 years ago

I should probably mention the endscreen is also missing, playlist or not, which might be part of the problem. Remove endscreen is not toggled.

Yonezpt commented 10 years ago

Last time I checked it was working well, the only thing that wasn't working as it should for me was the auto-play button showing up on youtube generated playlists (https://github.com/YePpHa/YouTubeCenter/issues/885#issuecomment-55529643).

What options from that "Auto play" section in YTC do you have enabled? Do you happen to have "Playlist auto-pay freeze" activated?

greatwroth commented 10 years ago

I've already answered this, I edited my second post to make sense since the posted question was removed.

greatwroth commented 10 years ago

Here is something that should really help; this only happens with the HTML5 player. I avoid using the flash player as much as possible because it has some very annoying issues. Recently though the HTML5 player has been slowly breaking down to the point it will randomly stop loading the video when I seek or even just start a video. This forces me to temporarily switch back to the flash player because it at least consistently plays. I really don't know who to blame for this but my guess is youtube just because they have made themselves an easy target at this point and all other HTML5 players work just fine so it can't be firefox.

Yonezpt commented 10 years ago

Then perhaps the way the HTML5 player interacts with the playlist might be different than with how the flash player interacts, causing the function to "break". If that is the case then it should be easy to detect the problem now that it appears to be restricted to playlists + html5.

gwarser commented 10 years ago

I have the same issue, but I think Adblock is causing this. On Fx 33b7 disabling ABP fix this.

greatwroth commented 10 years ago

That does work but the HTML5 player is still nearly unusable and actually causes firefox not to close properly if if the infinite buffer problem happens. I did some extensive testing and the problems are not caused by any of my mods but by firefox itself; chrome utilizes the youtube HTML5 player perfectly (though I'm not surprised).

greatwroth commented 10 years ago

This issue (along with most other issues with the youtube html5 player) is fixed in Aurora (Firefox alpha channel), current version is 34.0a2. I've posted the remaining issues to the mozilla support forum.