search

YehorFeshchenko / renju-game

0 stars 0 forks source link

Combine 2 methods? #5

Open IanaKhitsko opened 1 month ago

IanaKhitsko commented 1 month ago

https://github.com/YehorFeshchenko/renju-game/blob/8cb6f1dd25e63c998f3f445ef1cc800a3e0572af/main.go#L29C6-L29C21

Is there any way to combine these two methods (checkHorizontal and checkVertical)? they are too similar

YehorFeshchenko commented 1 month ago

Good point. To improve readability and maintain clean code practice, two methods were merged into one, checkLines.

The issue addressed in changes in this MR: https://github.com/YehorFeshchenko/renju-game/pull/6

YehorFeshchenko commented 1 month ago

@IanaKhitsko