YehudaKremer / msix

Create Msix installer for flutter windows-build files.
https://pub.dev/packages/msix
MIT License
280 stars 70 forks source link

[FEATURE-UPDATE] installCert = _args || yaml, instead of installCert = _args && yaml #101

Closed theshivamlko closed 2 years ago

theshivamlko commented 2 years ago

Problem: On remote computer like Codemagic CI/CD for Windows, terminal ask user input to proceed, Do you want to install the certificate: "navoki_notes.pfx" ? (y/N)

and install-certificate is not passed in command line. SignTool command is also added signtool_options but still ask user input in terminal

signtool_options: "/v /t http://timestamp.digicert.com /fd sha256 /f navoki_notes.pfx /p 123456789 build\\windows\\runner\\Release\\NavokiNotes.exe"

Same configuration works on local PC.

Solution Either variable is accepted to use or skip install-certificate to make build and release on auto-pilot mode

Change installCert = _args['install-certificate'] != 'false' && yaml['install_certificate'] != 'false'; TO installCert = _args['install-certificate'] != 'false' || yaml['install_certificate'] != 'false';

YehudaKremer commented 2 years ago

Thank you @theshivamlko

I published new version (3.1.0) with fix (did same fix configurations flags/options)