Closed BentEngbers closed 1 year ago
Hello @BentEngbers
Looks like a very good PR.
I will be happy to test it and approve it in a few days, please be patient 🙏
Big thanks for your contribution
@skyeskie hello,
Only if you have free time,
Do you have opinion on the patchbuild+build
change here:
https://github.com/BentEngbers/msix/blob/main/doc/msix_version.md#the-append_build_number_to_patch-configuration-flag
PR: https://github.com/YehudaKremer/msix/pull/192
Our previous discussion: https://github.com/skyeskie/msix_config_version_match/issues/1
Thank you
I think that append build number to the patch number is too opinionated approach, and may not suit everyone.
Also, adding a configuration specifically for this seems unnecessary to me.
I know you invested a lot in this PR including good tests,
but I don't think it's worth adding it while we have alternative way using the explicit msix_version
configuration.
Closes #185.
How the flag works can be found in the documentation