YehudaKremer / msix

Create Msix installer for flutter windows-build files.
https://pub.dev/packages/msix
MIT License
276 stars 68 forks source link

[BUG] after updating v3.12.0 from v3.9.1, signing failed. #194

Closed p1318k closed 1 year ago

p1318k commented 1 year ago

:information_source: Info

Version: v3.12.0

:speech_balloon: Description

Regradless of flutter sdk version (3.10.0 or 3.7.12), it fails. It worked only with v3.9.1 package in my case.

Here are some logs.

[ +49 ms] executing: C:\flutter\bin\cache\dart-sdk\bin\dart __deprecated_pub run msix:create -v --signtool-options /tr http://timestamp.digicert.com /td SHA256 /fd SHA256 /n 'SK Telecom Co.,Ltd.' [ 0.013s] parsing cli arguments [ 0.116s] validating config values [ 0.119s] running "flutter build windows"... [ 54.297s] building msix files... [ 54.298s] validating build files [ 54.306s] cleaning temporary files [ 54.314s] create app icons [ 54.315s] generating icons [ 1m 02.534s] copying VC libraries [ 1m 02.544s] getting certificate publisher Unhandled exception: invalid certificate subject: SK Telecom Co.,Ltd.

0 SignTool._checkCertificateSubject (package:msix/src/sign_tool.dart:78:7)

1 SignTool.getCertificatePublisher (package:msix/src/sign_tool.dart:48:7)

2 Msix._buildMsixFiles (package:msix/msix.dart:114:24)

#3 Msix._createMsix (package:msix/msix.dart:98:5) #4 Msix.create (package:msix/msix.dart:57:5) #5 main (file:///C:/Users/kimki/AppData/Local/Pub/Cache/hosted/pub.dev/msix-3.12.0/bin/create.dart:4:3) [+65903 ms] "flutter run" took 66,044ms. [ +3 ms] pub finished with exit code 255 [ ] #0 throwToolExit (package:flutter_tools/src/base/common.dart:10:3) #1 _DefaultPub.interactively (package:flutter_tools/src/dart/pub.dart:586:7) #2 PackagesForwardCommand.runCommand (package:flutter_tools/src/commands/packages.dart:250:5) #3 FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:1257:27) #4 AppContext.run. (package:flutter_tools/src/base/context.dart:150:19) #5 CommandRunner.runCommand (package:args/command_runner.dart:209:13) #6 FlutterCommandRunner.runCommand. (package:flutter_tools/src/runner/flutter_command_runner.dart:283:9) #7 AppContext.run. (package:flutter_tools/src/base/context.dart:150:19) #8 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5) #9 run.. (package:flutter_tools/runner.dart:64:9) #10 AppContext.run. (package:flutter_tools/src/base/context.dart:150:19) #11 main (package:flutter_tools/executable.dart:91:3)
YehudaKremer commented 1 year ago

Hello

Maybe its related to the recently PR: https://github.com/YehudaKremer/msix/pull/190

Do you have config value in the publisher: field under msix_config: ? if so, try to delete publisher field, and run again (let the package automatically detect the certificate "Subject")

p1318k commented 1 year ago

Okay, I wll try. Thanks for the reply.

p1318k commented 1 year ago

@YehudaKremer it is working. Thank you.