YehudaKremer / msix

Create Msix installer for flutter windows-build files.
https://pub.dev/packages/msix
MIT License
276 stars 68 forks source link

feat: locate msix assets path from script file directory if necessary #197

Closed lijy91 closed 1 year ago

lijy91 commented 1 year ago

When I depend on msix in another package, the msix assets path cannot be obtained when calling create. I added the logic to find the package config from the directory where the script file is located.

List<String> arguments = [];
// ...
await Msix(arguments).create();

https://github.com/leanflutter/flutter_distributor/blob/a112f0a82cf10041f856154415dcb5e0de1d2c89/packages/flutter_app_packager/lib/src/makers/msix/app_package_maker_msix.dart#L59

YehudaKremer commented 1 year ago

Hello

I will try to test and approve this PR in the next day

Thank you

YehudaKremer commented 1 year ago

LGTM 👍

Available in version 3.13.1

Thank you @lijy91