search

YehudaKremer / msix

Create Msix installer for flutter windows-build files.
https://pub.dev/packages/msix
MIT License
281 stars 69 forks source link

[BUG] Embedded App Installer Not Loading Updates #229

Open eraps7 opened 1 year ago

eraps7 commented 1 year ago

:information_source: Info

Version: ^3.16.1

:speech_balloon: Description

Thank you for a great package! I see there has been hours of work put into this project.

I ran dart run msix:publish to create the app installer. I then followed the instructions found on Microsoft docs (click me) to embed the app installer file that was created using dart run msix:publish into the MSIX file. After completing the instructions I installed the new MSIX that has the app installer embedded and the application doesn't check for updates. I also tried to run dart run msix:publish again to create a new version so that I would receive a prompt to upgrade to the new version. That didn't work either. It seems that the application bypasses the update check when the app installer is embedded.

Any advice or guidance is greatly appreciated on how to successfully embed the app installer into the MSIX. I would like to contribute to this project and create a pull request for this issue.

Side note: On the Microsoft docs, (click me) they use xmlns="http://schemas.microsoft.com/appx/appinstaller/2021" for the app installer file. The project currently uses xmlns="http://schemas.microsoft.com/appx/appinstaller/2018" in the creation of the app installer file. I tried to update the xmlns to "http://schemas.microsoft.com/appx/appinstaller/2021" but then I received the error below. I wonder if the xmlns value being 2018 is related to the application not checking for updates when the app installer is in embedded.

error

:scroll: Pubspec.yaml

name: my_msix description: A new Flutter project. publish_to: 'none'

version: 1.0.0+1

environment: sdk: '>=3.0.1 <4.0.0'

dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.2

dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^2.0.0 msix: ^3.16.1

flutter: uses-material-design: true

msix_config: display_name: My MSIX App certificate_path: xxxRemovedForPrivacyxxx certificate_password: xxxRemovedForSecurityxxx app_installer: #<-- app installer configuration publish_folder_path: xxxRemovedForPrivacyxxx hours_between_update_checks: 0 automatic_background_task: true update_blocks_activation: true show_prompt: true msix_version: 1.0.3.0

Thank you for reading!

YehudaKremer commented 1 year ago

Hello @Eradparvar

Embedded app-installer is not yet supported with this package. It will be good future feature.

eraps7 commented 1 year ago

Thank you, @YehudaKremer, for the quick response. Would you like me to create a pull request for this feature? Can you provide any guidance on what I should focus on to implement this?