YehudaKremer / msix

Create Msix installer for flutter windows-build files.
https://pub.dev/packages/msix
MIT License
280 stars 70 forks source link

[BUG] Icons-background-color always set to blue no matter what I set #69

Closed shadow5688 closed 2 years ago

shadow5688 commented 2 years ago

:information_source: Info

Version: v2.6.6

:speech_balloon: Description

As stated in the title itself, the icon_background_color is always shown blue (or whatever accent color is) in final built package, no matter what I write in config.

:scroll: Pubspec.yaml

msix_config:
  display_name: BlackHole
  publisher_display_name: Ankit Sangwan
  identity_name: com.shadow.blackhole
  icons_background_color: transparent
  logo_path: assets/ic_launcher.png
  msix_version: 1.0.0.0
  # file_extension: .mp3, .m4a
YehudaKremer commented 2 years ago

Hello @Sangwan5688

What windows version you working with? (see in settings -> system -> about -> version:???)

shadow5688 commented 2 years ago

@YehudaKremer I'm on Windows 11 Pro 21H2 (OS Build 22000.376)

YehudaKremer commented 2 years ago

From version 20h2 and above, windows don't showing background colors anymore you can read about this here: https://docs.microsoft.com/en-us/windows/whats-new/whats-new-windows-10-version-20h2#windows-shell image

You can work around this by adding background color to your icon itself.

I also a updated the documentation about this, thanks for this report.

shadow5688 commented 2 years ago

Ya, so actually the icon is fine in start menu. But during installation, in taskbar and in settings, it shows accent color as background.

During Installation: Screenshot (194)

In start menu (Looks fine here): Screenshot (196)

In taskbar or settings (Supposed to be look like first one but looks like second one): Screenshot (197)

YehudaKremer commented 2 years ago

Hello again

I publish new version (2.7.0) that fix the background color in the taskbar icon, you only need logo_path now. please read the changelog.

shadow5688 commented 2 years ago

Ok, So I tried using latest version, but looks like regardless of logo_path provided, it always create images of Flutter logo. Edit: The issue with transparency is fixed in taskbar icon though it looks same in app settings and during installation.

Still same during installation: Screenshot (216) Same in settings: Screenshot (214)

Fixed in taskbar (well that's more important) Screenshot (215)

YehudaKremer commented 2 years ago

i will check it, can please upload here your logo, i will check it too

shadow5688 commented 2 years ago

Sure, here's the logo

YehudaKremer commented 2 years ago

i upload new version (2.7.2) with fix to show your logo, please check if its working for you

shadow5688 commented 2 years ago

Ok, now it's creating right logo. There's still those boundaries in settings and during installation but it's fine main issue was with taskbar which is resolved.