YehudaKremer / msix

Create Msix installer for flutter windows-build files.
https://pub.dev/packages/msix
MIT License
278 stars 69 forks source link

[BUG] never asked about installing the test certificate #97

Closed abdelaziz-mahdy closed 2 years ago

abdelaziz-mahdy commented 2 years ago

:information_source: Info

Version: 3.0.0-dev.3

:speech_balloon: Description

Based on this sentance i expected to be asked if i want to install certificate or not the user is asked (cli dialog) if he wants can install the certificate (done with powershell) but i was never asked on cmd nor powerShell

How can i check if the test certificate was inastalled or not

code run with -v command

[  +64 ms] executing: [G:\My Work HDD2\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +545 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +2 ms] 5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c
[   +2 ms] executing: [G:\My Work HDD2\flutter/] git tag --points-at 5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c
[  +69 ms] Exit code 0 from: git tag --points-at 5f105a6ca7a5ac7b8bc9b241f4c2d86f4188cf5c
[   +1 ms] 2.10.0
[   +8 ms] executing: [G:\My Work HDD2\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +40 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[   +3 ms] origin/stable
[        ] executing: [G:\My Work HDD2\flutter/] git ls-remote --get-url origin
[  +41 ms] Exit code 0 from: git ls-remote --get-url origin
[   +2 ms] https://github.com/flutter/flutter.git
[ +114 ms] executing: [G:\My Work HDD2\flutter/] git rev-parse --abbrev-ref HEAD
[  +45 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[   +2 ms] stable
[  +79 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +7 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +8 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +54 ms] Artifact Instance of 'MaterialFonts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'GradleWrapper' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[        ] Artifact Instance of 'FlutterSdk' is not required, skipping update.
[        ] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IosUsbArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FontSubsetArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'PubDependencies' is not required, skipping update.
[ +106 ms] executing: G:\My Work HDD2\flutter\bin\cache\dart-sdk\bin\dart __deprecated_pub run msix:create -v
[     0.007s] parsing cli arguments
[     0.116s] validating config values
[     0.120s] updating Runner.rc "CompanyName" to "com.zcreations.AnimeHere"
[     0.121s] running "flutter build windows" command...
[    13.710s] restore Runner.rc content
[    13.713s] creating msix installer...
[    13.714s] validating build files
[    13.726s] cleaning temporary files
[    13.740s] creating app icons folder
[    13.741s] copying app icons
[    13.744s] generating icons
[    16.329s] copying VC libraries
[    16.336s] getting certificate publisher
[    17.084s] generate appx manifest
[    17.089s] generate package resource indexing files
[    17.258s] packing
[    24.997s] cleaning temporary files
[    25.258s] signing
msix created: [    30.089s] build\windows\runner\Release\anime_here.msix
[+31809 ms] "flutter run" took 32,046ms.
[ +186 ms] ensureAnalyticsSent: 180ms
[   +6 ms] Running shutdown hooks
[   +2 ms] Shutdown hooks complete
[   +2 ms] exiting with code 0

:scroll: Pubspec.yaml

msix_config:
  display_name: AnimeHere
  publisher_display_name: abdelaziz
  identity_name: com.zcreations.AnimeHere
  msix_version: 3.0.185.0
  logo_path:  G:\My Work HDD2\AndroidStudioProjects\anime_here\windows\runner\resources\app_icon.ico
  start_menu_icon_path: G:\My Work HDD2\AndroidStudioProjects\anime_here\windows\runner\resources\app_icon.ico
  tile_icon_path: G:\My Work HDD2\AndroidStudioProjects\anime_here\windows\runner\resources\app_icon.ico
  icons_background_color: "#00244a"
YehudaKremer commented 2 years ago

Hello

its automatically checking if the certificate installed, if not, its will ask you if you want to install it.

abdelaziz-mahdy commented 2 years ago

Hello

its automatically checking if the certificate installed, if not, its will ask you if you want to install it.

but on a diffrent pc the installer shows (untrusted app) so they cant install the app :_(

YehudaKremer commented 2 years ago

Hello @zezo357

The best way to distribute an app is with Microsoft Store, then you wont need to take care about the certificate any more. see documentation .

For test purposes, i added in version 3.0.0-dev.5 the --with-test-certificate-installer flag, when use it, it will add next to the .msix, a .exe file that will install the test-certificate on the user machine.

abdelaziz-mahdy commented 2 years ago

Hello @zezo357

The best way to distribute an app is with Microsoft Store, then you wont need to take care about the certificate any more. see documentation .

For test purposes, i added in version 3.0.0-dev.5 the --with-test-certificate-installer flag, when use it, it will add next to the .msix, a .exe file that will install the test-certificate on the user machine.

Just to be sure it will require them to start the exe before installing

Or it will be started automatically

YehudaKremer commented 2 years ago

They need to start the exe before installing

i don't think it can be integrated into the msix format 😞

abdelaziz-mahdy commented 2 years ago

They need to start the exe before installing

i don't think it can be integrated into the msix format 😞

sad

but thanks anyway♥

YehudaKremer commented 2 years ago

Update: The flag --with-test-certificate-installer is remove in version 3.1.5, see: https://github.com/YehudaKremer/msix/issues/106