Closed tyseer2335 closed 10 months ago
Okay, just few things (writing on my way home, so some spelling mistakes):
Main.java: Reverting changes in Main.java, specifically switching between InitializeGameState and InitializeTestGameState. Ensure that this reversion is necessary and doesn't introduce inconsistencies. Also, I see that you removed my old text-based calling codes, I will put it back (which I saved on Discord), we need to refer to README file and will be good for TA to understand the architecture of whole program.
UIAssets: It seems like you've added new UI assets for the winner & loser screens, including images like "4_hover.png," "lost.gif," and "win.png." Just make sure that these assets are appropriately sized and enhance the overall visual experience.
Main.java: Make sure that the added functionality aligns with the overall design and that the code is clear and readable. We need to make sure CA is applied, currently main takes in use case import, which causes conflict of clean code design & CA. We need to ensure it is replaced with interface calling use case.
PokemonListFromSpritesDataAcessObject.java Changes: Refactoring the code related to constructing the sprites folder path is a good practice. Ensure that this modification improves maintainability.
Pokemon.java: I see changes with a "totalHealth" attribute and modifying health-related methods. Make sure that these changes are consistent with the overall design, and test thoroughly to avoid introducing bugs.
(Minor) MenuController, MenuPresenter, MenuState, MenuViewModel Deletions: Similar to ViewModel.java, ensure that the removal of these files aligns with the project's architecture and doesn't break any dependencies.
Linked view to RunGame., and also added winner and loser screens, commented code for clarity. Added some new interfaces to implement input and Output data. Now the game is 100%, but we still need to figure out how to link up the views so the transition is nice, also we have to figure out how we can run the game with the Picking Pokemon UI we made.