search

YehyunLee / PokemonGame

Pokémon Battle Simulator allows players to engage in exciting turn-based battles using various Pokémon. The simulator is designed to provide a realistic and engaging Pokémon battle experience, complete with different moves, strategies, and outcomes.
https://docs.google.com/presentation/d/18OZ4ov5St6cAIvWGQH5LLCylErJciXATBBqE7P2hu-o/edit?usp=sharing
3 stars 3 forks source link

Java doctest for entities, partial improvement CA for GameView #60

Closed Muaj17 closed 10 months ago

Muaj17 commented 10 months ago

Added java doctests to all the entities. Unfortunately, I couldn't figure out how to make GameView.java/TestGameView.java not import from use_case and entity. I did make it adhere to CA a little more than it did before though as I edited a few files to make it so that GameView and TestGameView doesn't need to import data access objects. Perhaps someone else can help?

A side note, there were imports made in Main.java. I checked the week 5 coding homework and they did import a data access object so I assumed this is okay to do.

YehyunLee commented 10 months ago

I will give a detailed check. In fact main don't need import except menu view I believe. I will get java doc done for use case rn. TODO: javadocs (Muaj Entity, Yehyun all use cases, Tyseer Run game) interface (replace usecase) test cases api slides

YehyunLee commented 10 months ago

Love the improvement with CA for GameView with replacing data_access as interface.

I think we need to replace the entity and use case as well.

I will right now try and improve CA on this aspect.

We need to make sure the inner layer isn't modified by out layer

YehyunLee commented 10 months ago

This has been fixed and improved with CA. I improved game view CA dependency rule in our latest commit!