YellProgram / Yell

Yell is a program for diffuse scattering interpretation using the 3D-∆PDF refinement.
Other
12 stars 3 forks source link

Feature request: refine able variables from defined variables #34

Open k-eks opened 9 years ago

k-eks commented 9 years ago

Is it possible to declare some previously declared variables as "refineable"? For instance:

Cell 19.507 19.507 29.255 90.0 90.0 120.0 # volume is 9640
p1=0.7;
p2=1;
# other Yell statements
RefinableVariables [
p1 # just like this
]
´´´
The idea is to turn them on and off.
aglie commented 8 years ago

Oh, sorry, I missed when the bug appeared.

In principle at the moment I move the lower bracket of the RefinableVariables block. Like this:

RefinableVariables [
p1=0.5;
p2=0;
]

to something like

RefinableVariables [
p1=0.5;
]

p2=0;

By the way, I now can compile Yell again, so I can make any version of turning the variables on or off. I just do not know how to do this in the best way. Suggestions are welcome.

k-eks commented 8 years ago

Oh, I thought I read somewhere that variable declaration has to be before the refinable variables... I just thought it would be nice to have a simple switch to turn them on and off, so that you could do a first run like

p2=2;
RefinableVariables [
p1;
#p2;
]

and for the second run simply uncomment p2.

This is pure lazyness, it would come down to a few keystrokes more or less...

aglie commented 8 years ago

Ok, I see the point. Since there is no pressing need for this to work right now, I would schedule the change on some (possibly distant) future when I will make some serious improvements in Yell speed.