Locale-Related issues with UI and official content

Yellow-Dog-Man / Locale

Locale files for Resonite

MIT License

26 stars 101 forks source link

Locale-Related issues with UI and official content #30

Open JackTheFoxOtter opened 1 year ago

JackTheFoxOtter commented 1 year ago

A couple of locale related issues I've noticed while testing the German locale:

Regarding the Dashboard:

World.AccessLevel.FriendsOfFriends is still being used by world browser instead of World.AccessLevel.ContactsPlus
Search prompt, message prompt and the"Join" button appear to not be using locale strings (Search and Message have keys as far as I can tell: Contacts.SearchPrompt and Contacts.WriteMessage)
Exit screen doesn't appear to use locale string Dash.Exit.ThankYou

Regarding the official content:

Text on welcome Sign in front of Cloud Home doesn't auto-size
Music player / discs aren't using locale strings
nobr should be added around save and cancel buttons of color picker
The world panel doesn't appear to use CloudHome.FeaturedPanel.LinkText
There is no locale string for "All users Loaded" text on video player

JackTheFoxOtter commented 1 year ago

@ProbablePrime (And Aegis / Ryuvi but I can't @ them here)

ProbablePrime commented 1 year ago

I've got fixes out for the dash items.

@RyuviTheViali @AegisTheWolf the other items are all you guys :D

RyuviTheViali commented 1 year ago

Okay, all of these have addressed, and the missing string now has a pull request: https://github.com/Yellow-Dog-Man/Locale/pull/52

The only one that I'm not tending to is the disk labels - those are names of songs / artists / albums, and should remain user-editable.

JackTheFoxOtter commented 1 year ago

@RyuviTheViali for the disk labels I was more thinking using localizations for the default values of empty disk ("Empty Disk", "Album Name", "Artist Name"). However, I just realized they are directly pointing at the dynamic variables, I assumed those would be null by default and the default displayed values are grabbed from the NullContent of the Text components, which would be more easily localizable. If this structure is there for a reason, feel free to ignore my suggestion.

XDelta commented 1 year ago

Adding on to the World.AccessLevel. one, it is using the SessionAccessLevel enum tostring'd and appended to World.AccessLevel. to create the locale string. The FriendsOfFriends enum value is already marked as Obsolete in code, just needing its usages updated.