search

Yellow-Dog-Man / Locale

Locale files for Resonite
MIT License
24 stars 86 forks source link

fix: add missing keys for FBT and avatar calibration dialog #391

Closed stiefeljackal closed 3 weeks ago

stiefeljackal commented 3 weeks ago

This will add the missing keys Settings.Height, Settings.Metric, and Settings.Imperial that were removed during the transition from the old Settings screen to the new Settings screen. These keys are still used today for the Full Body / Avatar Calibration dialog that was reported in #270.

If new key names will be given to them, then I can update accordingly.

This fixes #270. This fixes https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/2279.

Banane9 commented 3 weeks ago

If they had translations in other languages, it would make sense to restore those in this PR too, as otherwise the linked issues will be closed by merging this PR without the problem being fixed for the other languages.

stiefeljackal commented 3 weeks ago

If they had translations in other languages, it would make sense to restore those in this PR too, as otherwise the linked issues will be closed by merging this PR without the problem being fixed for the other languages.

Makes sense. Restoring the previous keys from an earlier commit should be fine, so I will do that later today.

Banane9 commented 3 weeks ago

Makes sense. Restoring the previous keys from an earlier commit should be fine, so I will do that later today.

That'd be perfect 👍

stiefeljackal commented 3 weeks ago

Added missing keys for other locales based on a previous commit (25ce3868d90dc53dd7cedf8bc16b6b2d794e6a62); this is the last commit before these keys were removed. These values were from previous translators, so this should be okay.

stiefeljackal commented 3 weeks ago

Messed up the rebase, so I will close this PR for now. Existing keys might be used, so these legacy keys won't be included. I will create a new PR at a later point to fill in the values for General.Units.Metric and General.Units.Imperial with the same values from Settings.Metric and Settings.Imperial (minus the unit mentioned) for those locales that previously had them under the legacy keys but now missing.