search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
141 stars 2 forks source link

Implement AGX #1007

Open gentlecolts opened 11 months ago

gentlecolts commented 11 months ago

Is your feature request related to a problem? Please describe.

Agx is a very cool, very realistic view transform that has proven very popular through it's blender implementation

Describe the solution you'd like

Quick googling brings up a few reference implementations: https://github.com/sobotka/AgX - the original https://github.com/MrLixm/AgXc - reimplementations in various languages https://iolite-engine.com/blog_posts/minimal_agx_implementation - a shadertoy example

Describe alternatives you've considered

I don't really know if there's any truely viable alternatives other than maybe the older aces

Additional Context

zangooseoo

Frooxius commented 11 months ago

Can you provide more context for this? What is this used for? Why would you like it in Resonite?

gentlecolts commented 11 months ago

AGX is a view transform that's been shown to provide extremely effective handling of out-of-gamut/clipping colors in a graceful, appealing, and realistic way, especially notable for not over-saturating blown out colors

here is a video goes pretty in depth in terms of explaining the motivation, comparing vs filmic or ACES, subjective and objective advantages: https://www.youtube.com/watch?v=YsTQEzcmD5w

AGX has also become the default view transform for Blender, and is supported in others, and adopting the standard would help visual consistency between applications

Frooxius commented 11 months ago

I'm still not quite understanding how would this apply to Resonite and what problems it would solve.

Is this something global? Or would it be a feature users implement? Like a filter shader?

I don't have the time to watch 20 minute video unfortinatelly, that's a bit to steep.

Geenz commented 11 months ago

So generally for tonemappers - linear is your default. I don’t think we’re gonna be changing this beyond what would generally be recommended as part of a PBR pipeline (which would be ACES nowadays).

However, we do eventually want to add post processing effects for volumes and such where you can apply tone mapping effects (including fading between LUTs). This could be an option for that.

gentlecolts commented 8 months ago

Randomly found a really nice comparison: image image

gentlecolts commented 7 months ago

https://github.com/MrLixm/AgXc/ actually has a really great example shot too:

image