Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
122 stars 2 forks source link

NoIK tag not honored on any bones below the hand bone #1031

Open ikanimew opened 6 months ago

ikanimew commented 6 months ago

Describe the bug?

I have an avatar with several extra bones under the normal IK driven ones (moving panels and such). If there is a bone under the Hand bone that doesn't match up to the standard handposer, handposer setup fails, even if the bone has <NoIK> at the beginning of the bone name. This will happen if the bone is parented to any of the finger bones as well. If I parent the bones under the LowerArm bone, the handposer is set up correctly.

To Reproduce

Add an extra bone in Blender, parented under the Hand bone or a finger bone. Name it something like <NoIK>Panel.Left_wrist1 or <NoIK>Panel.thumb1-1.L respectively. Export as GLTF and import into Resonite. In the Avatar Creator, make sure "Set up hand posers" is checked and run through the standard avatar creation process. The creator will complete without error, though the HandPoser components will be missing.

Expected behavior

Expected that the setup of the HandPoser components would ignore any bones with <NoIK> in their name, and set up as if they were not there.

Screenshots

No response

Resonite Version Number

2023.12.21.1127

What Platforms does this occur on?

Windows

What headset if any do you use?

Vive Pro Eye

Log Files

DISPLACER - 2023.12.21.1127 - 2023-12-31 01_38_01.log

Additional Context

No response

Reporters

No response

shiftyscales commented 6 months ago

Could you please provide a sample avatar/asset which demonstrates this issue, @ikanimew?

ikanimew commented 6 months ago

noik-armature-test.zip This should have two GLB files, one which the HandPoser sets up correctly, with the added bones parented to LowerArm, and one which HandPoser will fail, with the added bones parented to the Hand and Thumb bones

shiftyscales commented 6 months ago

Thank you!

shiftyscales commented 4 months ago

Ran into this with an avatar a loved one was trying to set up last night. What all could be done here, @Frooxius @ProbablePrime? It seems like hand/finger components like the hand poser use a different system internally to the rest of the IK?

Would this be something that'd wait for the IK rework #612?

ProbablePrime commented 4 months ago

I'm familiar with this area and wrote some tests on my last time through that will help here.