search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
135 stars 2 forks source link

Switching to desktop with "F8" does not disable "mirror to display" if camera control panel is not open #1059

Open jae1911 opened 9 months ago

jae1911 commented 9 months ago

Is your feature request related to a problem? Please describe.

Sometimes, when I record a demo, I forget to turn off the "Mirror to Display" in the streaming camera, shutdown on all of my stuff and return to my desktop only to discover the game is still mirrored. This is very frustrating.

Describe the solution you'd like

Add a desktop keybind to start/stop the display mirroring.

Describe alternatives you've considered

A mod could be made for that.

Additional Context

No response

JackTheFoxOtter commented 9 months ago

Actually, I think under some circumstances it does automatically disable mirror to screen when you switch to Desktop mode. However, that's not a good thing. I remember a couple of instances where VR hotswapping turned it off, which was the reason I disabled VR hotswapping, since if this happens while I'm streaming, it could potentially expose private information from my dash without me realizing. This should always be a manual setting, but perhaps instead of a shortcut, it could be a UI element that shows up when mirror to screen is on, but VR presence isn't detected. The game already has many shortcuts that confuse new users, I don't think we should add more (if they don't have a UI button as well).

shiftyscales commented 6 months ago

Based on my testing- it seems that if VR hotswitching is enabled, mirroring to display is disabled when taking off the headset/switching to desktop automatically.

When manually invoking the mode change with the F8 key, the mirror to display is not disabled.

This comes across to me as a bug- the expected behaviour should be that when switching to the desktop mode- mirroring to the display is disabled- matching the behaviour that occurs when taking the headset off while hotswitching is enabled.

I'd suggest that switching to the desktop mode with F8 should also disable mirror to display in the same way that it is disabled while hotswitching. @Frooxius @ProbablePrime

Regarding your point, @JackTheFoxOtter - if there are issues with the hotswapping mechanism being unreliable- they should be reported separately.

shiftyscales commented 6 months ago

Discovered an additional detail- the mirror to display does properly get disabled with F8 if the camera control panel is opened. If it is not open- then it fails/doesn't get disabled.

JackTheFoxOtter commented 6 months ago

Regarding your point, @JackTheFoxOtter - if there are issues with the hotswapping mechanism being unreliable- they should be reported separately.

That was not my point. My point was that mirroring to desktop should NOT be automatically disabled when the headset detects it has been taken off, since when streaming and the dash is open when you take the headset off, this will suddenly show your dash and potentially expose private information. I do not think mirroring should be disabled automatically under any circumstances, only on explicit button press (like it does when you press F8).

JackTheFoxOtter commented 6 months ago

But I can create a separate issue for that.