Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
135 stars 2 forks source link

Treat bones labeled as "Hip" like "Hips" when converting models to avatars with the Avatar Creator #1204

Open Thekster93 opened 8 months ago

Thekster93 commented 8 months ago

Is your feature request related to a problem? Please describe.

Recently I experienced the issue where the creator of an avatar labeled the hip bones as "Hip", the bone was thus not utilized, and the created avatar did not function correctly due to this missing hip bone.

1153 is the issue reference.

Describe the solution you'd like

Treat hip bones labeled as "Hip" like hip bones labeled as "Hips". This would result in that bone being assigned correctly as the hip bone when using the avatar creator to convert the model to an avatar.

Describe alternatives you've considered

Leaving current behavior intact. This would likely result in more instances of user confusion like I experienced due to being unaware that "Hip" is not treated the same as "Hips". Also confusion as this does not appear to be the an issue on other social VR platforms.

Additional Context

No response

Frooxius commented 8 months ago

This is a bit of a tricky issue, because we've had a number of avatars that use the word "hip" for the upper legs. We specifically don't detect "hip" as "hips", because this caused a number of avatars to report incorrectly due to the ambiguity.

We can make the system a bit smarter, so it can do additional analysis to determine if the "hip" refers to the leg or to the first segment of the spine.

What would be helpful here is to provide us with a sample rig (we don't need the mesh, just the skeleton structure), so we can look at it and run the import with it.

shiftyscales commented 8 months ago

Please provide a sample rig demonstrating this issue as requested above, @Thekster93.

Thekster93 commented 8 months ago

Apologies for the delay in response. I believe I have what you're asking for. I exported only the armature from Blender into the attached FBX. Please let me know if this isn't what you need as I am not skilled with Blender. Lykanos_Blender_3.4_ArmatureOnly.zip

shiftyscales commented 8 months ago

Having the armature only doesn't seem to work, as the lack of a skinned mesh weighted to that armature seems to prevent it from importing as an avatar/setting up the IK, @Thekster93. We'd need a sample rig with a mesh weighted to it.

TisFoolish commented 8 months ago

I went ahead and weight painted a box mesh to the hip bone Lykanos_Blender_3.4_Armature plus box.zip

shiftyscales commented 8 months ago

Thanks.