Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
139 stars 2 forks source link

Add confirmation option in inventory for equipping an avatar #1262

Open epicEaston197 opened 9 months ago

epicEaston197 commented 9 months ago

Is your feature request related to a problem? Please describe.

When I'm in Resonite I find myself editing my avatar sometimes and I can accidentally click equip when I meant to save my avatar and lose a lot of work so this option would be nice

Describe the solution you'd like

for there to be a confirmation to equipping an avatar similar to the one that you get when you click on an avatar in 3D space

Describe alternatives you've considered

None really except for maybe just clicking the save option instead next time and just cope with you losing hours of work?

Additional Context

this could be fixed with the inventory rework when that's eventually worked on but I still think this would be a good option for feature parity with 3D space

5H4D0W-X commented 9 months ago

The change tracking wouldn't be accurate because many avatars have systems that dynamically move, duplicate or destroy slots. In fact, if any change in a field is considered an unsaved change, simply having a write node or clothing toggle would count as an unsaved change. And when everything is considered an unsaved change, with time people will start skipping the warning out of habit, making it useless.

epicEaston197 commented 9 months ago

Yeah the diagnostics on what counts as an unsaved change would have to be thought out more what I gave was mostly an example maybe there could be a flux node that could mark your avatar having an unsaved change and the diagnostics would be up to the user

JackTheFoxOtter commented 9 months ago

Maybe a more generic approach would be making equipping avatars undoable?

epicEaston197 commented 9 months ago

That is interesting but don't know how that will be achieved I might rewrite the entire issue around that

shiftyscales commented 9 months ago

"Undoing" an avatar equip wouldn't always be possible, e.g. for avatars that destroy themselves when de-equipped.

I can accidentally click equip when I meant to save my avatar and lose a lot of work

Why do you lose the work? Is there some reason why you couldn't save the avatar while you have it equipped, or spawn out another avatar and switch into that?

I'm not sure I'm understanding the underlying issues you're having when making this request.

Frooxius commented 9 months ago

To add to Shifty's comments, this feels a bit like the wrong approach.

What exactly would you actually expect to be undone with this? Equipping an avatar can make a lot of things happen and a lot of them are not very nicely undoable.

The other part is, how do you equip the avatar on accident? There should be a context menu asking to confirm. Are you not getting that?

We could potentially add a way to temporarily block equipping.

epicEaston197 commented 9 months ago

No this is particularly pertaining to the dash it does not have a confirm option unlike 3D space which does and because the inventory buttons move around often the save option isn't in a reliable spot leading to me clicking equip by muscle memory

this could be fixed with the inventory rework when that's eventually worked on but I still think this would be a good option for feature parity with 3D space

I will update the GitHub issue to not be the ability to undo equipping but have a confirm option for equipping like in 3D space I'm sorry for the misunderstanding it took a lot of feedback to fully explain my ideal properly and how to go about my issue

@Frooxius I hope the revised issue is more understandable

shiftyscales commented 9 months ago

Oh- so you're editing the avatar while you're in it, @epicEaston197...?

epicEaston197 commented 9 months ago

Oh- so you're editing the avatar while you're in it, @epicEaston197...?

Yes I am I do this often

while yes I could just spawn out a copy of my avatar it still runs into the same issue after I'm done editing my avatar externally after i spawned it out I equip it then I want to save it leading to the same issue to where I could accidentally click the equip button

a confirmation dialogue in the inventory like 3D space is still nice to have