Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
134 stars 2 forks source link

Xiexe Toon seems to have an issue with vertex lighting (?) in mirrors when lights are disabled, making it look completely dark in certain circumstances. #1596

Open ModernBalloonie opened 5 months ago

ModernBalloonie commented 5 months ago

Describe the bug?

When lights are disabled in mirrors, it shows vertex lighting instead except for the world directional light. (I think)

All the shaders seem to have good vertex lighting (?), though specifically not on toon material.

I'll be testing this stuff in the cloud home.

Example: Lights enabled in the mirror, toon and PBS look fine

2024-04-03 21 35 48

Example: Lights are off in the mirror. Notice how everything is vertex lit, except for the toon material. It seems to be completely dark.

2024-04-03 21 39 05

This can cause avatars to look completely broken in the mirror if lights are disabled.

Note in the default cloud home, if I change the time to day, this happens:

Example: Lights disabled, time set to day. Toon seems to not be as broken due to the directional light.

2024-04-03 21 44 49

Example: Lights enabled for good measure, time set to day.

2024-04-03 21 46 22

To Reproduce

Go to the default cloud home

Change the time of day to night

Open mirror, make a toon material.

Notice when the lights are disabled on the mirror, it causes issues with specifically toon material.

Expected behavior

For toon to at least have some vertex lighting. (at least I think that's what's happening in the mirror when lights are disabled)

Screenshots

Added in the explanation.

Resonite Version Number

2024.4.3.1170

What Platforms does this occur on?

Windows

What headset if any do you use?

Desktop, Quest Pro

Log Files

DESKTOP-QBGCSAQ - 2024.4.3.1170 - 2024-04-03 14_50_04.log

Additional Context

No response

Reporters

modernballoonie on Discord.

shiftyscales commented 5 months ago

Seeking feedback from @Geenz.

Geenz commented 5 months ago

Probably going to defer this to the toon shader replacement.

Geenz commented 5 months ago

Due to the current complexity with Xiexe, I'm going to push this out to the toon shader replacement.