Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
130 stars 2 forks source link

Add mirror resolution override setting #1742

Open epicEaston197 opened 4 months ago

epicEaston197 commented 4 months ago

Is your feature request related to a problem? Please describe.

Right now users are limited to the mirror resolution options that are given by the world these options could be too limiting in some cases

Describe the solution you'd like

I want a setting that allows me to edit the mirror resolution to have a maximum value or override it altogether

Describe alternatives you've considered

Asking creators to add more resolution options

Additional Context

No response

Requesters

@epicEaston197

PJB3005 commented 4 months ago

This has been asked on Discord before and I'll repeat what I said then: mirrors shouldn't even work the way they do right now, so this request doesn't make much sense either.

Resonite's mirrors currently render at a fixed resolution. Instead they should render at the exact pixel size of the mirror surface on screen. This would improve performance and visual clarity in some cases. At that point a "mirror resolution divider" parameter or something might make sense, but not this proposal.

JackTheFoxOtter commented 4 months ago

Could be a good graphics option and fit in well with the planned max texture size. Max resolution for portals would be nice as well.

JackTheFoxOtter commented 4 months ago

This has been asked on Discord before and I'll repeat what I said then: mirrors shouldn't even work the way they do right now, so this request doesn't make much sense either.

Resonite's mirrors currently render at a fixed resolution. Instead they should render at the exact pixel size of the mirror surface on screen. This would improve performance and visual clarity in some cases. At that point a "mirror resolution divider" parameter or something might make sense, but not this proposal.

That would be separate to the proposed setting here.

epicEaston197 commented 4 months ago

Could be a good graphics option and fit in well with the planned max texture size. Max resolution for portals would be nice as well.

That's actually what made me make this issue I saw it and I was thinking a Max mirror size would also be a good option to have

especially for portals because most creators don't put setting limits on those but that might have to be a separate issue if it doesn't use the same underlying system that mirrors do

Frooxius commented 4 months ago

We can add this as part of the quality settings.

@PJB3005 That's a lot more complicated request, that will take significant time to implement. It's something we can look into, but questions are how is that going to fit into the rendering pipeline and with the shaders/materials that can be used with the mirror - this adds more complexity.

Such mirrors would likely have to use stencils to render into a buffer which could then be sampled. But that requires more extensive changes to the graphical pipeline to achieve that, so it might not even happen until we switch our renderer engine away from Unity.

In the meanwhile, it makes sense for this setting to manage performance of current implementation.


Cameras & Portals are technically the same thing (just configured differently), so they would be covered under the same setting.

epicEaston197 commented 4 months ago

I would still appreciate being able to configure the Max resolution for mirrors and portals because they're both used in a very different context portals usually have a higher resolution to give off the illusion of there being a window mirrors on the other hand can get away with being a lower resolution