Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
138 stars 2 forks source link

Provide the ability to disable motion blur via a setting #178

Closed Nammi-namm closed 6 months ago

Nammi-namm commented 1 year ago

Is your feature request related to a problem? Please describe.

Many people have complained about motion blur being forced on in desktop mode. They would like to be able to turn it off. To some it is headache inducing, especially at lower framerates.

Describe the solution you'd like

Describe alternatives you've considered

Additional Context

There is a mod for disabling motion blur https://github.com/Raidriar796/MotionBlurDisable

Rellik66 commented 1 year ago

This was brought up during today's office hours, TLDR; the settings need to be reworked before this will be considered.

But as a stopgap, might I propose a command line option?

kulzae commented 1 year ago

I know this is waiting for a larger settings rework that would likely include other graphics settings but one of the reasons why this is requested so often is the game becomes a smeary unplayable mess at lower framerates due to it. While 20fps normally would be uncomfortable its nearly unusable due to the motion blur. The issue is the effect of the motion blur increasing the lower the framerate is.

you can reproduce this on nvidia hardware by going to the nvida control panel and setting the max framerate of the game to 20.

while i would like to see a more encompassing graphics setting selection adding a checkbox for this as a stopgap for lower end users untill the menu is reworked would be beneficial in my opinion

Enverex commented 1 year ago

I've been told the team don't want to touch the Settings page due to issues with it, so why not a launch option in the same way we can toggle other features, e.g. CTAA via the -CTAA flag instead for now. For example there could be a -NoBlur switch to disable motion blur.

ProbablePrime commented 12 months ago

To add on from office hours, there's a bunch of problems in place here so let's discuss them

Problems with Adding a Motion Blur Setting

  1. The Settings panel is bursting at the seams. Adding settings is difficult and prone to errors
  2. The settings system(how they're stored, saved, loaded, recalled and accessed) needs an overhaul, Adding settings is difficult and prone to errors
  3. We need to implement it in a way that makes sense for our rendering path going forwards.

Alternatives to the Above

From that we usually get:

To that:

  1. The command line flag system needs an overhaul, it is difficult to manage and add settings
  2. The config system needs an overhaul, it is difficult to manage and add settings

Why not turn it off by default

The last item we have is that some users say: "Why not just turn it off by default". To that end, the company has made the decision to leave this "on" as in some cases this can make items look better. We understand that some of you may disagree but that's the decision that has been made.

Do we plan to allow you turn it off.

Yes, once we're able to see: Problems with Adding a Motion Blur Setting

Conclusion

At least we now have a self-contained, single response to most common questions regarding it. This way Rumors and misinformation can be combatted.

While some of you may disagree with the items here, they are what they are. We will get to them when we're able to. Thank you.

troyBORG commented 11 months ago

Just to throw it in there. But what about doing something like the Settings Redux mod. https://github.com/XDelta/SettingsRedux

That way instead of saying "its at capacity" split it out into different groups so you have room to add stuff for the time being until you get an actually overhaul of the settings menu completed..

CakePost commented 11 months ago

the company has made the decision to leave this "on" as in some cases this can make items look better. We understand that some of you may disagree but that's the decision that has been made.

I would just like to put my name on the list as someone who disagrees with this decision. That's all.

ProbablePrime commented 11 months ago

Just to throw it in there. But what about doing something like the Settings Redux mod. XDelta/SettingsRedux

That way instead of saying "its at capacity" split it out into different groups so you have room to add stuff for the time being until you get an actually overhaul of the settings menu completed..

Doing this would qualify as a "settings re-work" which is the work required in Item 1 of my response. Additionally the settings re-work should be a separate issue.

Once again we're not "not" doing it because we do not know how, we're not doing it because of other matters, other priorities or the appropriate work requiring more thought.

Meister1593 commented 11 months ago

What about command line setting that other people have already done? It does not seem to be a massive hassle to implement it as some people have demonstrated in the past. And it will satisfy pretty much all the needs for the community in the mean time while it's being properly developed.

The way i see it myself as this is being treated as something unimportant right now, while it's in fact a massive burden on community. And responding with "some items look better with it" doesn't make any sense, at least to me, where motion blur could be genuinely nauseating for some people.

CakePost commented 11 months ago

To that end, the company has made the decision to leave this "on" as in some cases this can make items look better.

I'm genuinely curious what items look better. Having insight into this might help alleviate some of the confusion. Some examples here would go a long way to better direct the conversation.

ProbablePrime commented 11 months ago

What about command line setting that other people have already done? It does not seem to be a massive hassle to implement it as some people have demonstrated in the past. And it will satisfy pretty much all the needs for the community in the mean time while it's being properly developed.

The way i see it myself as this is being treated as something unimportant right now, while it's in fact a massive burden on community. And responding with "some items look better with it" doesn't make any sense, at least to me, where motion blur could be genuinely nauseating for some people.

A command flag is covered in a previous response, thank you.

FlameSoulis commented 11 months ago

And responding with "some items look better with it" doesn't make any sense, at least to me, where motion blur could be genuinely nauseating for some people.

Bumping this because this is becoming more and more common in the Steam Discussions. This is slowly becoming less of a tolerable issue, and I'm kind of surprised this is still an issue given how much of a complaint this was in NeosVR.

Frooxius commented 11 months ago

We'll tackle this as part of this: https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/584

I think prioritizing the setting UI rework soon is better use of our time and energy at this point. This is a particularly noticeable issue, but there's lots of others as well and number of things are made more difficult by not having a proper system in place.

shiftyscales commented 11 months ago

Added the 'setting' and 'accessibility' labels to this, and have prioritized it accordingly. Thank you for the recommendation.

Frooxius commented 6 months ago

With #584 this is now unblocked :3 Just saying!

Frooxius commented 6 months ago

This is now implemented in 2024.4.17.1420 along with a few things! IT HAS COME! AAAAAA!