Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
132 stars 2 forks source link

[Setting] dash resolution scale #1819

Open epicEaston197 opened 4 months ago

epicEaston197 commented 4 months ago

Is your feature request related to a problem? Please describe.

For some users the default resolution of the camera that renders their dash might be too high or too low for their specific needs for example the pimax headsets these headsets have ridiculous amount of visual clarity that the dash could look pixelated

Describe the solution you'd like

A setting in user interface called DashResolutionScale this will be a slider input and will modify the camera resolution that is rendering the dash

as a side note this could also help performance but not the main goal of this issue the camera for the dash could also be disabled when tapped out of Resonite

Describe alternatives you've considered

Going in user space and manually editing the resolution of the camera that's rendering the dash

Additional Context

No response

Requesters

@epicEaston197

shiftyscales commented 4 months ago

for example the pimax headsets these headsets have ridiculous amount of visual clarity that the dash could look pixelated

Are you speaking from experience? Or is that speculation?

This issue is sounding similar to the other issue you had opened previously, #1443.

the camera for the dash could also be disabled when tapped out of Resonite

The camera is already disabled when the dash is closed. Doing it when Resonite is not the focused window would not be suitable, e.g. if you were using the desktop tab from within VR and navigated to another application, it would make the dash unusable if the camera turned itself off.

as a side note this could also help performance but not the main goal of this issue

Based on comments made from Frooxius previously in the linked issue- using a camera should be a fairly performant way of rendering this UI- especially since it is only active while it is being rendered, and is only rendering a single hierarchy.

I double-checked things- and the camera resolution already changes itself to match the resolution of the screen the user is viewing it on- so it seems to do what you want it to already, and there would be no real purpose or benefit to manually scaling the dash resolution beyond that which I could see, @epicEaston197.

epicEaston197 commented 4 months ago

Are you speaking from experience? Or is that speculation?

The camera is already disabled when the dash is closed. Doing it when Resonite is not the focused window would not be suitable, e.g. if you were using the desktop tab from within VR and navigated to another application, it would make the dash unusable if the camera turned itself off.

overall I don't think this setting will be used that often but on some lower end devices like the steam deck or other Android handhelds could benefit from this

shiftyscales commented 4 months ago

Do you have any metrics that indicate this option would provide the performance benefit you claim?

When it comes to getting Resonite working on low-spec/mobile hardware, there are a lot more prominent issues which would have a much more significant impact towards that goal, e.g. #702, #706 (.net version bump), #1401, etc.

Frooxius commented 4 months ago

For lower end devices we'd probably make this automatic change.

Generally the dash shouldn't be very heavy to render even on lower end PC's, so I'm not sure if there's much value in this setting.

The only thing that would help is having higher resolution if you want extra crispness, but I don't know if it's really that blurry in very high resolution headsets.

If we get people with some of those headsets asking for this, we could implement this.

JackTheFoxOtter commented 4 months ago

For lower end devices we'd probably make this automatic change.

Generally the dash shouldn't be very heavy to render even on lower end PC's, so I'm not sure if there's much value in this setting.

The only thing that would help is having higher resolution if you want extra crispness, but I don't know if it's really that blurry in very high resolution headsets.

If we get people with some of those headsets asking for this, we could implement this.

Even without a high-resolution headset, I find the dash pretty blurry sometimes when I scale it up to read something small (Valve Index). Especially compared to the SteamVR dashbord. I just doubled it for testing, and definitely prefer it that way. It's noticably sharper.

shiftyscales commented 4 months ago

Have you tried disabling post-processing, e.g. anti-aliasing, and Bloom, @JackTheFoxOtter? I've found those can have a fairly drastic impact to Resonite's clarity as a whole, including the dash, particularly the desktop screen.

In my experience with the SteamVR dash- it can also be fairly blurry too if you are using the medium/high quality setting on it- setting the SteamVR dash to low quality seems to sharpen it up considerably, but also causes more aliasing/shimmering.

A similar result could probably be seen by setting the RenderTextureProvider for the dash to use point filtering instead of bilinear filtering, which would likely make the output more crisp, but cause aliasing/shimmering.