Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
140 stars 2 forks source link

SessionActiveInput Level Protoflux node does not have all selections #182

Open jman96-png opened 1 year ago

jman96-png commented 1 year ago

Describe the bug?

When trying to make a simple equals node for World Access Level. the SessionActiveInput Level node does not have "friends" or "friendsoffriends" able to be selected in the list

To Reproduce

Get the World Access Level node for protoflux Get the equals node for protoflux Connect the World Access Level node to the equals node Drag out the other unconnected wire from the equals node to get the SessionActiveInput Level node Scroll to the selections to see the missing options/selections

Expected behavior

Expected all selections of the World Access Level node to be in the SessionActiveInput node.

Screenshots

https://cdn.discordapp.com/attachments/746904601697189969/1162979391928807507/20231014233850_1.jpg

Resonite Version Number

Beta 2023.10.13.743

What Platforms does this occur on?

Windows

What headset if any do you use?

Valve Index

Log Files

JOEL-PC2022 - 2023.10.13.743 - 2023-10-15 00_18_57.log

Additional Context

No response

Reporters

Pepper_Panda on discord

ProbablePrime commented 1 year ago

Thank you for making this issue, this issue is a little odd.

Friends and FriendsOfFriends are Obsolete values and our code base should not be using them. I'll see why worlds are having this value set.

lxw404 commented 10 months ago

I've just run into this as well... It would be nice for all valid enums to be available for this node as it's currently impossible to check if a session's active state is Contacts or ContactsPlus, since this node reports Friends and FriendsOfFriends instead and no SessionAccessLevel input values exist for the former.

Frooxius commented 10 months ago

These values should be equivalent.

If you compare FriendsOfFriends it should equal ContactsPlus

lxw404 commented 10 months ago

That is the issue here, there is no way to construct either of those inputs. The input node itself does not have the options.

TisFoolish commented 10 months ago

What Froox is saying is that if the World Access Level node outputs FriendsOfFriends just compare it to ContactsPlus; You shouldn't need the obsolete values since they should be equivalent

lxw404 commented 10 months ago

I would urge you to try to do so to verify that I'm not going crazy... If you try to pull out an input node, the input node itself has only exactly the following options in its enum list to compare to:

Lexevolution commented 10 months ago

Just verified, on latest version (2024.1.3.1265), that the SessionAccessLevel enum doesn't seem correct. Here's a video for reference:

https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/31176843/522c0720-0ed1-492a-8b35-0b6054c1c6b0

ProbablePrime commented 6 months ago

This is still occuring as of Beta 2024.4.26.1258, I accidentally ended up in this issue and decided to test it because Froox handled #1057

JackTheFoxOtter commented 2 days ago

This issue is still relevant. It doesn't only affect the ProtoFlux node though, you can also not choose all access levels when manually editing the SessionAccessLevel enum in the scene inspector. As a workaround you can manually copy existing Contacts or ContactsPlus values (for example from the WorldAccessLevel Node) to a SessionAccessLevel field using a Write<SessionAccessLevel> node.

As for the incorrect names, it appears to me that while the names of the enum values have been changed to Contacts and ContactsPlus, the ToString function still returns "Friends" and "FriendsOfFriends" respectively, which is why they are shown as such on a Display<SessionAccessLevel> node. Image