search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
102 stars 0 forks source link

Use user profile picture instead of world thumbnail for join/leave notifications #1963

Open amplified1 opened 1 week ago

amplified1 commented 1 week ago

Is your feature request related to a problem? Please describe.

Profile pictures are highly recognizable and can be used to quickly identify someone you are familiar with without reading the text contents of the notification, and the world thumbnail just doesn't feel like the best use of that space in terms of aesthetics and utility in my opinion.

Describe the solution you'd like

replace, or have an option to replace (more customization is always good) the world thumbnail shown in join/leave notifications with the joining/leaving user's profile picture. Much like user online notifications.

Describe alternatives you've considered

both could be shown, but that may be too busy, another setting possibility perhaps.

Additional Context

No response

Requesters

@_amplified_

epicEaston197 commented 1 week ago

You're experiencing a bug I see profile pictures

Frooxius commented 1 week ago

Yes, it should show both the profile and session thumbnail.

Can you provide a screenshot of what your notifications look like?

epicEaston197 commented 1 week ago

Yes, it should show both the profile and session thumbnail.

Wait I've only ever seen profile pictures. How is the session thumbnail supposed to fit both?. And what would the use case be showing the session thumbnail?.

shiftyscales commented 1 week ago

Session thumbnail could give additional context about the specific world, e.g. if two sessions were just called "User's World".

I just saw the profile pic and session thumbnail in a notification, so as far as I can see, it is working as intended.

Does the user you received the notification about have a profile image assigned, @amplified1?

amplified1 commented 1 week ago

didn't realize it was a bug, I will do some testing (disabling mods, etc) and give information when I can

epicEaston197 commented 1 week ago

Session thumbnail could give additional context about the specific world, e.g. if two sessions were just called "User's World".

I don't see this being useful because right now user join leave notifications is scoped to the current session you're in I have yet to see a profile picture and a session thumbnail that would only make sense if the join leave notifications notified you of users leaving in sessions you're not currently focused in

this is currently how I have my notification settings set up image

shiftyscales commented 1 week ago

Well, that was requested in #1943, @epicEaston197 - but I don't see any harm in it being there regardless.

epicEaston197 commented 1 week ago

Well, that was requested in #1943, @epicEaston197 - but I don't see any harm in it being there regardless.

Yeah that's understandable that's gonna be a setting in the future but I don't understand how you're receiving session thumbnails that is what's confusing me here

shiftyscales commented 1 week ago

It is on the right side of the notification- do you not see them, @epicEaston197?

epicEaston197 commented 1 week ago

It is on the right side of the notification- do you not see them, @epicEaston197?

No I don't believe I've ever seen a session thumbnail on the right side of the user join/leave notification it's either that or I completely ignored it or the thumbnail just didn't load in

epicEaston197 commented 1 week ago

I can confirm I do not see a session thumbnail image only a profile picture @shiftyscales image

shiftyscales commented 1 week ago

Hmm- is that a session you are hosting, @epicEaston197? Or someone else's? What is the visibility of that session?

epicEaston197 commented 1 week ago

Hmm- is that a session you are hosting, @epicEaston197? Or someone else's? What is the visibility of that session?

I wasn't hosting the session and it was a publicly viewable session

epicEaston197 commented 1 week ago

okay now i'm only getting session thumbnails this user had a profile icon it's either I get one or the other image i provided a log file i'm using mods it's lengthy because of how long i've been in Resonite this probably isn't useful because of the mods I'm running but who knows it might have some information that might be useful DESKTOP-DAN95E7 - 2024.5.4.678 - 2024-05-06 05_44_42.log

epicEaston197 commented 1 week ago

okay now I'm receiving both the session thumbnail looks really forced in there it doesn't even follow the rounded corners and again I don't see much use in this (I've not closed my game since my last comment) image okay now I'm only receiving the thumbnail image again it's seamlessly random if you get the profile image and the session thumbnail or only the profile image or only the session thumbnail