Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
111 stars 0 forks source link

Add privacy setting to strip EXIF image data on import #2015

Closed ProbablePrime closed 2 days ago

ProbablePrime commented 3 weeks ago

Is your feature request related to a problem? Please describe.

  1. Most cameras these days are smart devices, that record information such as the GPS coordinates of a photo. These are saved to an area of the photo file called "EXIF" data(https://en.wikipedia.org/wiki/Exif). image
  2. Privacy minded users would like this information not to be included when an image is imported in Resonite.]

Describe the solution you'd like

  1. A setting that when enabled, will automatically strip any EXIF information from an image on import.

Describe alternatives you've considered

Requiring users to strip EXIF before they import.

Additional Context

  1. I took a look and FreeImage actually... mostly supported this. (see: https://github.com/Yellow-Dog-Man/FreeImage/pull/14)
  2. Therefore its easy to flow into our existing image importing/exporting flows.

This report came via the ticket desk as a security issue, but I see it as more of a privacy feature, additionally as the FreeImage changes need to be public due to the nature of FreeImage, it makes sense to open a public issue.

Requesters

No response

EmergencyTemporalShift commented 3 weeks ago

Glad it got implemented, thanks for the work.

ProbablePrime commented 3 weeks ago

Not yet, we're on the way to though!

ProbablePrime commented 3 weeks ago

WIP: https://www.youtube.com/watch?v=2H9LBQ1LywA

TisFoolish commented 3 weeks ago

Can you please include info in the description that the data can include location? I know that the description mentions GEOTIFF metadata, I just fear that is far too technical for most users and won't understand what that means.

ProbablePrime commented 3 weeks ago

Sure!

ProbablePrime commented 3 weeks ago

Updated: https://github.com/Yellow-Dog-Man/Locale/commit/3e24f71b6d23adcaf1454c321d359c2ecc475b96

TisFoolish commented 3 weeks ago

I think that works!