search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
134 stars 2 forks source link

SteamLink Face Tracking OSC address typo #2100

Closed hazre closed 3 months ago

hazre commented 3 months ago

Describe the bug?

So I was going through Froox's new SteamLink face tracking code and I think there seems to be a typo for the address /sl/xrfb/facew/TongueOut, so the tongueout expression might not be even working? (I can't test, I don't own a Quest Pro anymore)

It should be /sl/xrfb/facew/TongueOut instead of /sl/xrfb/facew/ToungeOut.

To Reproduce

See if Tongue out expression works?

Expected behavior

To Tongue come in and out.

Screenshots

image

Resonite Version Number

2024.5.24.202

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

N/A

Additional Context

No response

Reporters

@hazre

hazre commented 3 months ago

It's possible Valve has added a fallback for that address, so the misspelled version still works. Again I can't test, so I don't know.

troyBORG commented 3 months ago

I had my tongue already setup previously, and it still working after the new update.

Originally with the Vive Face Tracker, then using Cyro's Mod that let Steam Link OSC work, and now with the official support. Tongue still triggers.

Frooxius commented 3 months ago

Oh that's a good catch! I didn't even notice this. I just dumped the OSC data and copied the strings from it for the mapping.

I've had a closer look at the data SteamLink sends and apparently they send both versions - with and without typo. I must've copied the typoed version when I was making the mappings:

image

From what I can tell, it's sending the exact same data.

I'll switch it to the non-typo one just to be sure.

hazre commented 3 months ago

Yeah that's what I assumed as well, since I saw other facetracking software also using the mistyped version originally and then switching to the correct one. Seems like a whoopsie on valve's end.

ModernBalloonie commented 3 months ago

Oh that's a good catch! I didn't even notice this. I just dumped the OSC data and copied the strings from it for the mapping.

I've had a closer look at the data SteamLink sends and apparently they send both versions - with and without typo. I must've copied the typoed version when I was making the mappings:

image

From what I can tell, it's sending the exact same data.

I'll switch it to the non-typo one just to be sure.

Unrelated but I find it funny that valve would make a typoed one just in case you spelt it wrong.

hazre commented 3 months ago

Oh that's a good catch! I didn't even notice this. I just dumped the OSC data and copied the strings from it for the mapping. I've had a closer look at the data SteamLink sends and apparently they send both versions - with and without typo. I must've copied the typoed version when I was making the mappings: image From what I can tell, it's sending the exact same data. I'll switch it to the non-typo one just to be sure.

Unrelated but I find it funny that valve would make a typoed one just in case you spelt it wrong.

Again it seems like Valve made the typo first and then fixed it but they kept the misspelled version in for compatibility.

Frooxius commented 3 months ago

Switched the path in 2024.5.30.68, thanks!