Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
139 stars 2 forks source link

A way of knowing a users monitor type (LCD or OLED) #2291

Open epicEaston197 opened 4 months ago

epicEaston197 commented 4 months ago

Is your feature request related to a problem? Please describe.

Right now it is hard to visually optimize content for LCD vs OLED for example my avatar is a little emissive on LCD headsets but when someone views my avatar from an OLED headset it is way too bright

Describe the solution you'd like

I would like to be able to adjust things according to a users monitor type/headset display

Describe alternatives you've considered

Optimizing for only OLED but this result in LED being more dull

Additional Context

The glow on my avatar is driven to 3, 3, 3, 1 this enables my avatar to have a slight glow around it but when viewed from an OLED headset it is really bright

Requesters

@epicEaston197

ko-tengu commented 4 months ago

There's literally no way to get this information and even across this there's a billion and a half other settings that would affect color reproduction such as headset brightness, windows color calibration, streamer choice and settings, mods, etc.

I will note that 3,3,3,1 is intended to be extremely bright and if it's a slight glow you may want to look at your own settings.

epicEaston197 commented 4 months ago

There's literally no way to get this information

yeah and that's what I thought unfortunately but i decided i might not know the whole story so I just made an issue anyway another solution to this is possibly hard coding it to headset type

I will note that 3,3,3,1 is intended to be extremely bright and if it's a slight glow you may want to look at your own settings.

my bloom settings are default image and I mean it is a slight glow what I mean by this is the glow of the green is cascading on the black creating a green to black gradient image image

Nytra commented 4 months ago

You know you could texture it so it has a fade from green to black without being emissive

JackTheFoxOtter commented 4 months ago

This is not a optimization that should be done on user content level. If anything there might be a case for changing default settings depending on display type, but even that likely won't be practical because of the variance of different displays / configurations. If the bloom is too bright on someones display, it can be turned down. But as others have already pointed out, the display technology itself is only one of many factors that play into how something looks on screen. Most notably, it also depends on the displays configuration. Exposing this would likely lead to people building in special handling for separate display types, which at the end of the day would just make it harder for people to adjust their experience, since if you change your graphics settings to adjust for your display for the default shaders / conditions, now any user-made solution would be over- or undercorrecting.

Your avatar is also kind of the worst-case for this, the perceived variance on PBR avatars or toon shaded avatars that don't have full saturation is going to be a lot less severe. Green is also the color the human visual system is most sensitive to (https://en.wikipedia.org/wiki/Color_vision), which makes this appear more intense than other colors would.

But there's also a privacy concern. Any piece of information about someone's hardware can be used for tracking purposes. There's already a bunch of information exposed, and it might not be a massive issue today, but I'd still be careful about exposing additional information, especially if there is non or questionable benefit of exposing it.