Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
122 stars 2 forks source link

Turn only default option results in worse tool usage #2309

Closed ko-tengu closed 1 week ago

ko-tengu commented 3 weeks ago

Describe the bug?

With the recent change to add and default to a turn only option for your offhand, when you grab a tool the offhand stays turn only and a user is entirely unable to move. This also affects using the laser to grab items with Index controllers.

To Reproduce

Equip a tool or laser grab an object and attempt to move with the offhand.

Expected behavior

For the game to detect that you've only got one available hand and fall back to the previous one handed style control scheme. This is how this problem is handled on other platforms and games when one of your hands is overridden by settings or tools.

Screenshots

No response

Resonite Version Number

Beta 2024.6.11.74

What Platforms does this occur on?

Windows

What headset if any do you use?

Quest 2

Log Files


Additional Context

I don't want a full reversion of this, I think how it works with the default is fine when you're empty handed, but especially on the Quest this basically made the tool problem far worse.

Reporters

No response

epicEaston197 commented 3 weeks ago

I think this would be fixed just by having the ability to move while holding a tool be a thing

Frooxius commented 3 weeks ago

It's been coded to automatically change the movement to be turn + move on a single joystick if one of the joysticks is used by something else (e.g. a tool).

Can you please share a screenshot of your settings so we can replicate this?

@epicEaston197 You can already to that for some tools. But if the tool is using the joystick, locomotion can't use it.

epicEaston197 commented 3 weeks ago

@epicEaston197 You can already to that for some tools. But if the tool is using the joystick, locomotion can't use it.

I've noticed this when I was equipping the dev tool I'm unable to move when it's equipped which is not desirable behavior image

Frooxius commented 3 weeks ago

@epicEaston197 That's because right now, it uses the joystick, which means it can't be used for locomotion.

We can look into it not needing to use joystick, but that's separate issue from this, because even if that one is fixed, there will still be other things that might need to take control of the joystick.

epicEaston197 commented 3 weeks ago

@epicEaston197 That's because right now, it uses the joystick, which means it can't be used for locomotion.

The dav tool doesn't need to use the movement of the joystick it only uses the clicking function every single default tool in the game requires a secondary action meaning that you're not able to move with most default tools all because they only require the clicking action of the joystick i think if you separate the requirement from movement vs joystick clicking that would be preferable

Frooxius commented 3 weeks ago

This is not really the place to discuss that.

Like I said, even if the devtool didn't use it, other things might - and the bug will still be an issue. We need to resolve the bug reported in the original issue.

epicEaston197 commented 3 weeks ago

Ohh I'm sorry about that so the intended behavior is for it to automatically turn the other controller to "turn and move" when a tool is equipped?

ko-tengu commented 3 weeks ago

I attached a video showing the issue along with a log for completeness sake. https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/89536622/585ffed5-3158-47bc-97e4-f7da1d7a372c

BUFU - 2024.6.11.74 - 2024-06-12 18_27_54.log

xavion-lux commented 3 weeks ago

It's been coded to automatically change the movement to be turn + move on a single joystick if one of the joysticks is used by something else (e.g. a tool).

Can you please share a screenshot of your settings so we can replicate this?

@epicEaston197 You can already to that for some tools. But if the tool is using the joystick, locomotion can't use it.

From my observations, I think the current behavior is that when someone is grabbing an object with the laser of their primary hand, the locomotion setting of the primary hand gets applied to the free hand instead of forcing turn and move on a single joystick as intended.

For example someone having turn only on their right joystick grabbing something with the laser of their right hand, will have turn only be applied to the left hand.

I have double checked this by making left my primary hand and setting my left joystick to off, and ended up being unable to turn or move with my right joystick at all when grabbing an object using the laser of my left hand. Switching my left hand to turn and move would then fix the unintended behavior.

This probably wasn't noticed before because turn only didn't exist yet but it now being the default people end up only being able to turn but not move when grabbing an object with the laser of their right hand.

shiftyscales commented 3 weeks ago

Confirming the reported behaviour- with the configuration of left hand strafe, right hand turn only, I am unable to move forward with either hand while on Touch controllers, @Frooxius. This applies both to grabbing an object remotely and equipping a tool to either hand.

https://github.com/Yellow-Dog-Man/Resonite-Issues/assets/54213390/fcad896a-3fe9-4a5d-ae2f-aec3d36a4ddb

SHIFTY-LAPTOP - 2024.6.11.74 - 2024-06-13 15_29_31.log

Stellanora64 commented 3 weeks ago

Had some new users that were stuck due to this, are there any updates on this?

shiftyscales commented 3 weeks ago

If we have an update on an issue, it will be posted to the issue, @Stellanora64.

As far as I can see- this issue has all it needs to be looked into by @Frooxius who is currently assigned to it- it just needs time.

As it stands- this issue was reported less than a week ago, and there has since been a weekend in-between as well as other priorities to take care of- so your patience would be appreciated.

Frooxius commented 1 week ago

I've made a fix in 2024.6.25.1149, thanks!

Just a note for next time please - if we request screenshot, please provide the screenshot instead of video. The video made it much harder for me to parse what is going on and get the key piece of information I needed from it to fix this.