Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
134 stars 2 forks source link

Clamp the sprites in DynamicSpriteFont component #2677

Open SilvyPaws opened 1 month ago

SilvyPaws commented 1 month ago

Is your feature request related to a problem? Please describe.

I use this component in a project but the sprites have ugly lines around them when not viewed up close. This issue is because the images are not clamped.

Describe the solution you'd like

I'd either like them to be clamped by the component automatically or for there to be wrapping modes available to clamp them ourselves

Describe alternatives you've considered

No other alternatives.

Additional Context

No response

Requesters

SilvyPaws

Frooxius commented 1 month ago

It's not possible for them to be clamped because they are atlased.

We can add mechanism to add spacing between them to prevent this from happening. It would help to include some screenshots and other data on the issue you're experiencing for this.

SilvyPaws commented 1 month ago

It would help to include some screenshots and other data on the issue you're experiencing for this.

Next time I'm on Resonite, I shall do this!

SilvyPaws commented 1 month ago

It's not possible for them to be clamped because they are atlased.

We can add mechanism to add spacing between them to prevent this from happening. It would help to include some screenshots and other data on the issue you're experiencing for this.

Sorry it's been a hot minute, haven't really been on resonite, anyways! I did some testing and this issue seems to only appear to happen when it's in a UIX Text Renderer, not a "physical" text renderer.

These pictures are on a UIX canvas

Move far from the canvas with DynamicSpriteProvider, you can see some artifacts on the patreon logo image Up close, they seem fine image

shiftyscales commented 1 month ago

That sounds like it's an issue with the generated mipmaps then. As Frooxius indicated above, having a mechanism to add extra padding should prevent that bleedover from occurring in the generated mips.

Thanks for the additional information, @SilvyPaws.

SilvyPaws commented 1 month ago

That sounds like it's an issue with the generated mipmaps then. As Frooxius indicated above, having a mechanism to add extra padding should prevent that bleedover from occurring in the generated mips.

Thanks for the additional information, @SilvyPaws.

What ever the solution is, I'm happy to help!