Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
135 stars 2 forks source link

ResoniteBot reports success when attempting share storage while below the Builder Patreon tier #2712

Open ikanimew opened 1 month ago

ikanimew commented 1 month ago

Describe the bug?

I am currently at the Trailblazer Patreon tier, and mistakenly thought I could share storage with users as well as groups. In attempting to do so, the ResoniteBot reported that sharing was successful, even though the actual sharing correctly failed.

To Reproduce

From an account with a Patreon tier below "Builder," issue the following command to the ResoniteBot: /shareStorageWithUser Username 10GB The bot will respond with: "Updating storage..." "Storage updated! You are currently sharing 10.00GB of your storage, with user Username. They're currently allocated 0.00B. The shared amount will update automatically whenever your available storage updates."

Expected behavior

Ideally, the bot should return a failure message, indicating that the current account doesn't have access to sharing with users, and to look at Patreon if desired.

Screenshots

2d49cb3446786b5e4261349f0b8da244 2230c17f9176bddf31e50421494bec80

Resonite Version Number

2024.7.25.1284

What Platforms does this occur on?

Windows

What headset if any do you use?

Vive Pro Eye

Log Files

As this is a ResoniteBot issue, I skipped the log files for now. If desired, I can generate them.

Additional Context

No response

Reporters

Ikani

Frooxius commented 1 month ago

This is not a bug. In the latter part of the message, it states that they currently have allocated 0 bytes from your sharing - because you don't have enough to share.

The command to share storage is independent of how much storage you currently have to share - as that changes (e.g. when you upgrade Patreon tier or when you downgrade/cancel), the actual shared amount gets recalculated.

What this means is if you set storage to share and you currently don't have any, it won't be able to allocate any to that user, but if you do gain shareable storage later, it will be updated appropriately.

We could see about improving the messaging with that command to make it more clear - especially in case where you don't have any amount of storage to share.

ikanimew commented 1 month ago

Understandable! And yeah, I think improving the messaging there is what I'm after.