search

Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
135 stars 2 forks source link

Poor Quality Sound on LibVLC Audio Sources #282

Open Enverex opened 11 months ago

Enverex commented 11 months ago

Describe the bug?

Pulling this one over from the Neos tracker because it looks like it still applies to Resonite too, for people that want to track this specific problem.

Original logged issue:

A long time ago there was a complaint about video audio quality where it sounded like it was using a bad resampler. I've not noticed that specific issue for some time, but I've noticed this issue on several sound sources since then.

Here's what it should sound like (imported into Neos as an MP3 file, it's been converted to an OGG here for the sake of Discord): https://cdn.discordapp.com/attachments/439422161657135106/782319452763062282/GoodAudio.ogg

Here's what it sounds like in Neos (recorded from Neos directly using Audacity): https://cdn.discordapp.com/attachments/439422161657135106/782319500829392906/BadAudio.ogg

It sounds like it's been run through the worlds worst resampler, there's also a bunch of pops and clicks too. Additionally, if I change the playback speed, it doesn't change, it just starts skipping around instead.

To Reproduce

Pull in an audio file or stream that apparently needs re-sampling to a video player. An example would be http://142.132.143.174:8282/stream

Expected behavior

For the audio to sound as-per the source.

Screenshots

No response

Resonite Version Number

2023.10.13.743

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

N/A

Additional Context

Froox originally specified (https://github.com/Neos-Metaverse/NeosPublic/issues/1505#issuecomment-748511728) that this is due to LibVLC handling the sample-rate conversion:

This is an old issue, a better resampler was implemented months ago when the issue was originally brought up. If resampling happens in the libVLC then Neos unfortunately can't do anything about it anymore, we'll have to wait for switch to official libVLC library.

Geenz is currently working on an update the VLC implementation so hopefully that will resolve this.

Reporters

Enverex

epicEaston197 commented 11 months ago

Hey small tip if you're going to be making GitHub issues that's gonna be here for a few months or years I would highly recommend not using discord CDN as they're going to be applying more restrictions to those links

Enverex commented 11 months ago

Hey small tip if you're going to be making GitHub issues that's gonna be here for a few months or years I would highly recommend not using discord CDN as they're going to be applying more restrictions to those links

I'm aware, those were posted over 3 years ago.

shiftyscales commented 7 months ago

Yeah- this would likely be covered by the VLC upgrade. Can you please provide a replication file that exhibits the issues described, @Enverex? The source files you'd previously linked are no longer available, and having a file here to test against would be necessary to make sure this issue is resolved.

TisFoolish commented 7 months ago

Using the trick of posting the links in Discord to generate ones with the proper tracker code, I was able to grab the OGG files

GoodAudio.zip

BadAudio.zip

I had to zip them as I could not post them as naked OGG files.

shiftyscales commented 7 months ago

That wasn't what I needed, @TisFoolish. I needed a file to replicate this issue within Resonite.

sctanf commented 3 months ago

I experienced this same issue for a long time, through specifically any audio stream, like a live video or web radio. Playing any live video or live audio stream through any video player is audibly worse than through an external player or through a web browser.

I tested with multiple streams but here is one: http://bassdrive.radioca.st/

rabbuttz commented 1 month ago

@shiftyscales you can replicate it within Resonite by pasting these URLs in Resonite.

44100Hz (maybe this one will be resampled in Resonite) resdb:///f36739c9657af46a014c0557bf1c658285b2f007df0611bd84275ee4dbb11e72.brson

48000Hz (maybe this one will not be resampled in Resonite) resdb:///34e222a3249f0177d40403c2f58a0f91383b30aabfb5faf934738fbbe84e61c9.brson

If you watch youtube video in Resonite, it chooses 44100Hz video. Because of it, now YouTube Videos in Resonite sounds horrible.