Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
134 stars 2 forks source link

Import process occasionally leaves garbage in skinned mesh hierarchy #2844

Open ko-tengu opened 1 week ago

ko-tengu commented 1 week ago

Describe the bug?

Occasionally on importing skinned meshes, Resonite fails to clean up after Assimp and leaves a number of false bones with long names in the hierarchy.

To Reproduce

Import a model affected by this bug and examine it in the inspector.

https://booth.pm/en/items/5614226 This avatar's demo version (faafaa-vrc-free_1.1.2.zip) produces this issue 100% of the time on my testing.

Expected behavior

The Assimp working slots to get properly removed.

Screenshots

20240902165600_1

Resonite Version Number

2024.8.5.1341

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

BUFU - 2024.8.5.1341 - 2024-09-02 16_53_24.log (starts at ln 1238; 4:55:04 PM.538 , ends at ln 1441; 4:55:28 PM.190)

Additional Context

This bug has been around for a while but I can't find a previous report on it. It's even on some of the default tool models last I looked.

Reporters

No response

Frooxius commented 1 week ago

Which ones are you referring to specifically? Do you mean the $AssimpFbx$ ones?

If those are the ones that you mean, those are necessary by how Assimp imports FBX and some of its transforms. Removing those is something that would need to be done on Assimp's side - we just import whatever hierarchy Assimp says there is.