Some videos may crash users at lower FPS

[Dusty-Sprinkles]

Describe the bug?

I'm not 100% sure of this issue as I don't have a way to easily lower my fps myself, but recently when loading into a world I crashed with a unity error (provided below) and have confirmed this does not happen normally with or without mods which probably rules them out as the reason why.

To Reproduce

Play This Video while lagging or loading a world maybe? (still not sure what actually caused it)

Expected behavior

Videos should not crash users

Screenshots

N/A

Resonite Version Number

2024.8.5.1341

What Platforms does this occur on?

Windows

What headset if any do you use?

Index

Log Files

A log where the crash did not occur with mods off (I replicated this with mods on but I don't imagine it is relevant here) DESKTOP-GCR6JOJ - 2024.8.5.1341 - 2024-09-02 18_01_50.log

The logs of the crash DESKTOP-GCR6JOJ - 2024.8.5.1341 - 2024-09-02 12_10_25.log Video Player Crash Player.log

Additional Context

The world is typically very heavy (I usually get like 15 fps tops) so I'm leaning towards lag being the main cause but I wanted to submit this because it seems like the video player should just fail to load or something rather than outright killing me

Reporters

Venport/Dustysprinkles

[jligeza]

As asked in the linked issue, I created a gridspace world with only videos to hopefully reproduce the bug.

This world has many youtube videos that can significantly lower FPS or even crash SteamVR: resrec:///U-wizard-level-80/R-cd84fa14-4c1d-4371-ae6e-ebee3d81bbfc

This world has even more videos, but they are pulled from Resonite database instead of youtube, and for these I couldn't reproduce the issue: resrec:///U-wizard-level-80/R-46c5f543-3264-4ce7-bd9b-e0ef39ac7887

The details of how this issue behaves I described here: https://github.com/Yellow-Dog-Man/Resonite-Issues/issues/2577

[shiftyscales]

In a suspected duplicate report #2890 I found the crash logs were all pointing towards a video player causing a crash in overlay software.

Are you using any software overlays, e.g. Discord, Nvidia, Steam, etc. that are hooking into Resonite, @Dusty-Sprinkles @jligeza?

If so, could you try temporarily disabling them / adding Resonite as an exception so it doesn't try to hook into it and see if it resolves / lessens the issue?

In #2890 - the video source was also an external video from YouTube- the logs had mentioned the video was incompatible.

Also a quick note @Dusty-Sprinkles - when providing any subsequent log files could you provide all of the error.log / Player.log files as well as the standard Resonite log files?

Details on the different kinds of logs and where to find them are on the wiki: https://wiki.resonite.com/Log_Files

[Dusty-Sprinkles]

error.log Here's what should be the error log (its from the same day as this report at least) I don't really get this frequently enough to disable my overlays (I'm not usually watching as many videos as I watched that day on resonite itself, normally i'll just listen to music.

I do use like, 3 overlays though (xsoverlay, ovr advanced settings, and steamvr) so that could be related yeah

[shiftyscales]

Thanks @Dusty-Sprinkles - as suspected gameoverlayrenderer64.dll shows as the same crashed module. So I think it may be the same underlying cause as the other linked issues. If it's not too much of an inconvenience it would be helpful to ensure the crash doesn't seem to occur if there are no overlays present.

There's not much else I can recommend on my end at this time- I do not make use of any overlays (Discord, Steam, Nvidia, etc.) and don't really tend to suffer from crashes with the same regularity as others seem to- especially since I recently capped my texture resolution so I no longer run out of VRAM.

[jligeza]

Disabling steam vr overlay, which was the only overlay I use, has no effect.