Yellow-Dog-Man / Resonite-Issues

Issue repository for Resonite.
https://resonite.com
138 stars 2 forks source link

. #29

Closed Frozenreflex closed 1 year ago

shiftyscales commented 1 year ago

When submitting an issue, please follow our repo's best practices and fill all fields as completely as you can, including submission of a log file(s) produced by replicating the issue.

shiftyscales commented 1 year ago

Yes, @Frozenreflex. I'd also advise that whatever remaining issues you have that contribute to the state of the build be reported in a new issue here too rather than assuming malice.

I am still getting caught up on the 200+ issues that opened over the weekend, so if the issues already exist, please link me to them here so that they can be triaged, and resolved.

Thanks.

shiftyscales commented 1 year ago

Per our best practices I would also like to remind you to use objective, and respectful language for any issues and comments submitted to our repo, @Frozenreflex.

Gawdl3y commented 1 year ago

I don't see anyone insulting you - you may need to re-read Shifty's reply, as they were just suggesting that you shouldn't assume that anyone here is trying to be malicious with what they say, which it does seem like you're assuming. As a completely regular member of the community without inside knowledge, I assume that logs are requested for every bug report for a multitude of reasons; it simplifies troubleshooting, reduces the potential need for manual reproduction, and helps ensure that there aren't other things interfering. Plus, quite honestly, not everybody can be expected to know when a log does or does not make sense to add, so it's just a blanket request to ensure it's there regardless.

More to the topic at hand, Geenz posted a preview of the libVLC upgrade in the Discord #devlog channel (specifically, this message and this message) they're working on. From prior discussions on the matter from the old platform (assuming it still applies), this is the main blocker for Linux video player functionality. When this upgrade gets finished and implemented in an update, I assume that video players on the native Linux build will be fully-functional! 🤞

Gawdl3y commented 1 year ago

You didn't get to read what I said before they censored me. I didn't assume malice in the first place and it's insulting to me to accuse me of assuming malice like that, then delete my message going against that. I feel double insulted that you also assume I assumed malice. I didn't assume malice on my first reply, I just speak bluntly. Now that I've been censored, I absolutely assume malice.

Your words are coming across to me as quite hostile, and I don't think that I'm the only one that would think so. "Speaking bluntly" is not really a great reason for this usually. I consider myself to speak rather bluntly most of the time, but still try to word things in ways that avoid unintentional ire. Perhaps you don't intend on being hostile at all, which I absolutely would believe - in that case, I'd offer the friendly suggestion of consciously wording things in a more friendly/less controversial manner.

This is not an average case. I decompiled the game and figured out exactly why the bug was happening, and wrote a fix for it myself, then proceeded to link to that fix on the Neos Github, where I proceeded to get basically no official response. There (was) no need for logs because the fix was sitting right in front of them, and were they not overhauling the video players now, they could just apply the fix and it would work fine. Given that I gave them the fix such a long time ago, they could've easily included it in the Resonite launch.

I'm sure the team appreciates the additional effort you put into this, but that doesn't really mean you deserve a pass to skip a required step of the issue reporting process, at least in my mind. Logs should basically always be present on bug reports, unless it truly isn't applicable at all.

I am well aware of what Geenz is doing, and I think it's rather redundant because they're both going to ditch Unity in the future and it seems like they're just breaking video players on Linux even more. It also seems that nobody is reading what the fix I made actually is, because the blocker for video players on Linux in Neos was not some big overarching problem that would take a long time to solve and lots of overhauled code, it was two misconfigured strings, which is basically a one minute fix.

I can't comment on your suggested fix because I'm not knowledgeable enough on the matter. That being said, the libVLC update benefits everybody, not just Linux users, as it has far more consistency and support for codecs across all platforms than Unity ever will. The existing libVLC is a very old, custom implementation that replacing will greatly improve the stability and compatibility of. Plus, eliminating reliance on Unity is always good, as it's going the way of the dodo in the long-term for Resonite. The goal is to completely remove Unity from the equation and use a custom renderer (Sauce) and modern .NET runtime.

ProbablePrime commented 1 year ago

I've hidden the majority of comments on this thread as Off-Topic. I'd like for us to focus on the issue at hand which is Video Players being broken on Linux.

If someone can provide a log file, this will make this issue complete in terms of a report.

Thank you.

ProbablePrime commented 1 year ago

Thanks for the log file, I am now kicking this back to the Triage state.

Please keep all comments professional and respectful, or they will be hidden.

ProbablePrime commented 1 year ago

Shifty's comments are professional. They're reminders of our best practices and requests for information.

Thank you.

iamgreaser commented 1 year ago

It's probably worth opening a new issue saying more or less what needs to happen, and then taking the low-hanging fruit and JFDI - you get a bug fix that you didn't have to find yourself, and you make a notable minority of your community happy - notable because we host some of your most important headless servers :)

Considering how much the NeosVR Linux version has been completely and utterly shoved so far to the back of the queue of stuff to do that it's fallen off the edge, I can understand why Frozen would be so frustrated about this not being worked on. Hell, the fact that the Linux build never got the updated CloudX library despite being a fully-functional drop-in replacement was the final straw for me which motivated me to start making my own replacement for NeosVR from the ground up.

Anyway, this issue still needs to be tracked properly.

And Frozen: This is the sort of thing you should never attribute to malice.

Frozenreflex commented 1 year ago

And Frozen: This is the sort of thing you should never attribute to malice.

I didn't in the first place. Everyone else is saying I definitively did, and when I tried to tell them I wasn't I got censored and hidden. This entire thread was "harass Fro Zen with no repercussions, you're allowed to say whatever you want about him and he can't fight back". I deleted everything I said because I wanted to move on and hope nobody came to beat on me some more, but it seems like that's exactly whats happening.

It's probably worth opening a new issue saying more or less what needs to happen, and then taking the low-hanging fruit and JFDI - you get a bug fix that you didn't have to find yourself, and you make a notable minority of your community happy - notable because we host some of your most important headless servers :)

It's almost like that was what I did before it became a beatdown on me.